Re: [ovs-dev] [PATCH 4/4] lockfile: Implementation for Windows platform.

2014-02-13 Thread Gurucharan Shetty
On Thu, Feb 13, 2014 at 11:51 AM, Ben Pfaff wrote: > On Thu, Feb 13, 2014 at 11:22:23AM -0800, Gurucharan Shetty wrote: >> Start with a simple implementation that does not support >> symbolic links. >> >> Signed-off-by: Gurucharan Shetty > > This seems OK to me. > > ovs_lasterror_to_string() woul

Re: [ovs-dev] [PATCH 4/4] lockfile: Implementation for Windows platform.

2014-02-13 Thread Ben Pfaff
On Thu, Feb 13, 2014 at 11:22:23AM -0800, Gurucharan Shetty wrote: > Start with a simple implementation that does not support > symbolic links. > > Signed-off-by: Gurucharan Shetty This seems OK to me. ovs_lasterror_to_string() would be more convenient if it just returned sock_strerror(GetLastE

[ovs-dev] [PATCH 4/4] lockfile: Implementation for Windows platform.

2014-02-13 Thread Gurucharan Shetty
Start with a simple implementation that does not support symbolic links. Signed-off-by: Gurucharan Shetty --- lib/lockfile.c | 95 +--- 1 file changed, 90 insertions(+), 5 deletions(-) diff --git a/lib/lockfile.c b/lib/lockfile.c index d8f39