Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross wrote: > The GRE checksum is a 16 bit field stored in a 32 bit option (the > rest is reserved). The current code treats the checksum as a 32-bit > field and places it in the right place for little endian systems but > not big endian. This fixes the prob

Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 05:26:19PM -0700, Jesse Gross wrote: > On Tue, Mar 31, 2015 at 4:21 PM, Ben Pfaff wrote: > > On Mon, Mar 30, 2015 at 03:14:46PM -0700, Jesse Gross wrote: > >> The GRE checksum is a 16 bit field stored in a 32 bit option (the > >> rest is reserved). The current code treats t

Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-03-31 Thread Jesse Gross
On Tue, Mar 31, 2015 at 4:21 PM, Ben Pfaff wrote: > On Mon, Mar 30, 2015 at 03:14:46PM -0700, Jesse Gross wrote: >> The GRE checksum is a 16 bit field stored in a 32 bit option (the >> rest is reserved). The current code treats the checksum as a 32-bit >> field and places it in the right place for

Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-03-31 Thread Ben Pfaff
On Mon, Mar 30, 2015 at 03:14:46PM -0700, Jesse Gross wrote: > The GRE checksum is a 16 bit field stored in a 32 bit option (the > rest is reserved). The current code treats the checksum as a 32-bit > field and places it in the right place for little endian systems but > not big endian. This fixes

Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-03-30 Thread Pritesh Kothari (pritkoth)
LGTM Acked-by: Pritesh Kothari > On Mar 30, 2015, at 3:14 PM, Jesse Gross wrote: > > The GRE checksum is a 16 bit field stored in a 32 bit option (the > rest is reserved). The current code treats the checksum as a 32-bit > field and places it in the right place for little endian systems but >

[ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-03-30 Thread Jesse Gross
The GRE checksum is a 16 bit field stored in a 32 bit option (the rest is reserved). The current code treats the checksum as a 32-bit field and places it in the right place for little endian systems but not big endian. This fixes the problem by storing the 16 bit field directly. Signed-off-by: Jes