Re: [ovs-dev] [PATCH 3/9] tnl-ports: Generate mask with correct prerequisites.

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 14:47, "Jarno Rajahalme" wrote: > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> We should match on the transport ports only if the tunnel has a UDP >> header. It doesn't make sense to match on transport port for GRE >> tunnels. >> >> Also, to match on fragm

Re: [ovs-dev] [PATCH 3/9] tnl-ports: Generate mask with correct prerequisites.

2015-12-10 Thread Jarno Rajahalme
> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > We should match on the transport ports only if the tunnel has a UDP > header. It doesn't make sense to match on transport port for GRE > tunnels. > > Also, to match on fragment bits we should use FLOW_NW_FRAG_MASK instead > of 0xF

[ovs-dev] [PATCH 3/9] tnl-ports: Generate mask with correct prerequisites.

2015-12-09 Thread Daniele Di Proietto
We should match on the transport ports only if the tunnel has a UDP header. It doesn't make sense to match on transport port for GRE tunnels. Also, to match on fragment bits we should use FLOW_NW_FRAG_MASK instead of 0xFF. FLOW_NW_FRAG_MASK is what we get if we convert to the ODP netlink format