Re: [ovs-dev] [PATCH 3/8] ovn-nbctl: Update logical router port commands.

2016-06-12 Thread Ben Pfaff
On Sat, Jun 11, 2016 at 04:57:29PM -0700, Justin Pettit wrote: > > > On Jun 10, 2016, at 7:07 PM, Ben Pfaff wrote: > > > > On Fri, Jun 10, 2016 at 05:03:31PM -0700, Justin Pettit wrote: > >> > >>> On Jun 9, 2016, at 5:09 PM, Ben Pfaff wrote: > >>> > >>> I think that lrp-add with --may-exist s

Re: [ovs-dev] [PATCH 3/8] ovn-nbctl: Update logical router port commands.

2016-06-11 Thread Justin Pettit
> On Jun 10, 2016, at 7:07 PM, Ben Pfaff wrote: > > On Fri, Jun 10, 2016 at 05:03:31PM -0700, Justin Pettit wrote: >> >>> On Jun 9, 2016, at 5:09 PM, Ben Pfaff wrote: >>> >>> I think that lrp-add with --may-exist should report an error if the MAC >>> or NETWORK or [PEER] differ from the exist

Re: [ovs-dev] [PATCH 3/8] ovn-nbctl: Update logical router port commands.

2016-06-10 Thread Ben Pfaff
On Fri, Jun 10, 2016 at 05:03:31PM -0700, Justin Pettit wrote: > > > On Jun 9, 2016, at 5:09 PM, Ben Pfaff wrote: > > > > I think that lrp-add with --may-exist should report an error if the MAC > > or NETWORK or [PEER] differ from the existing port's configuration. > > Currently, adding the por

Re: [ovs-dev] [PATCH 3/8] ovn-nbctl: Update logical router port commands.

2016-06-10 Thread Justin Pettit
> On Jun 9, 2016, at 5:09 PM, Ben Pfaff wrote: > > I think that lrp-add with --may-exist should report an error if the MAC > or NETWORK or [PEER] differ from the existing port's configuration. Currently, adding the port fails if the port belongs to a different router. I assume you are suggest

Re: [ovs-dev] [PATCH 3/8] ovn-nbctl: Update logical router port commands.

2016-06-09 Thread Ben Pfaff
On Thu, Jun 09, 2016 at 12:12:37AM -0700, Justin Pettit wrote: > A few minor changes related to logical router port commands: > > - Use "lrp" instead of "lrport" to be more consistent with later > changes. > - Use commands where possible in ovn unit tests. > - Move documentation

[ovs-dev] [PATCH 3/8] ovn-nbctl: Update logical router port commands.

2016-06-09 Thread Justin Pettit
A few minor changes related to logical router port commands: - Use "lrp" instead of "lrport" to be more consistent with later changes. - Use commands where possible in ovn unit tests. - Move documentation to group router commands together. - Adds mac/network/peer to lrp-add c