Re: [ovs-dev] [PATCH 3/8] ofproto-dpif: Hide rule_dpif_miss_rule().

2013-08-05 Thread Ben Pfaff
On Sat, Aug 03, 2013 at 06:42:05PM -0700, Ethan Jackson wrote: > It's simple to hide it than to make it thread safe and ensure it stays > that way in the long term. > > Signed-off-by: Ethan Jackson I don't like how this duplicates logic in two places. Could we have this code in just one place p

[ovs-dev] [PATCH 3/8] ofproto-dpif: Hide rule_dpif_miss_rule().

2013-08-03 Thread Ethan Jackson
It's simple to hide it than to make it thread safe and ensure it stays that way in the long term. Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif-xlate.c | 26 +- ofproto/ofproto-dpif-xlate.h | 12 +++- ofproto/ofproto-dpif.c |7 +-- ofprot