Re: [ovs-dev] [PATCH 3/5] upcall: Refactor ukey creation and dump handling

2014-02-25 Thread Joe Stringer
Ah, great. The original refactoring was mostly split out from the patchset to get rid of the flow_dumper thread, which made it easier to split these statistics fixes out. I hadn't realised there was a bit more that we could do. On 25 February 2014 15:51, Ben Pfaff wrote: > On Tue, Feb 25, 2014

Re: [ovs-dev] [PATCH 3/5] upcall: Refactor ukey creation and dump handling

2014-02-25 Thread Ben Pfaff
On Tue, Feb 25, 2014 at 03:41:36PM -0800, Ben Pfaff wrote: > On Tue, Feb 25, 2014 at 03:25:35PM -0800, Ben Pfaff wrote: > > On Tue, Feb 11, 2014 at 01:55:34PM -0800, Joe Stringer wrote: > > > This splits out functions for re-use by later patches, and compacts the > > > udump revalidation code. > >

Re: [ovs-dev] [PATCH 3/5] upcall: Refactor ukey creation and dump handling

2014-02-25 Thread Ben Pfaff
On Tue, Feb 25, 2014 at 03:25:35PM -0800, Ben Pfaff wrote: > On Tue, Feb 11, 2014 at 01:55:34PM -0800, Joe Stringer wrote: > > This splits out functions for re-use by later patches, and compacts the > > udump revalidation code. > > > > Co-authored-by: Ethan Jackson > > Signed-off-by: Joe Stringer

Re: [ovs-dev] [PATCH 3/5] upcall: Refactor ukey creation and dump handling

2014-02-25 Thread Ben Pfaff
On Tue, Feb 11, 2014 at 01:55:34PM -0800, Joe Stringer wrote: > This splits out functions for re-use by later patches, and compacts the > udump revalidation code. > > Co-authored-by: Ethan Jackson > Signed-off-by: Joe Stringer I have this queued up to apply, thanks!

[ovs-dev] [PATCH 3/5] upcall: Refactor ukey creation and dump handling

2014-02-11 Thread Joe Stringer
This splits out functions for re-use by later patches, and compacts the udump revalidation code. Co-authored-by: Ethan Jackson Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 134 - 1 file changed, 78 insertions(+), 56 deletions(-) diff