On Wed, Mar 7, 2012 at 10:32 AM, Ben Pfaff wrote:
> On Tue, Mar 06, 2012 at 02:37:16PM -0800, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>
> This code in netdev_linux_get_etheraddr() looks awkward to me:
> if (netdev_dev->cache_valid & VALID_ETHERADDR) {
> goto out;
> }
On Tue, Mar 06, 2012 at 02:37:16PM -0800, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
This code in netdev_linux_get_etheraddr() looks awkward to me:
if (netdev_dev->cache_valid & VALID_ETHERADDR) {
goto out;
}
get_etheraddr(netdev_dev);
out:
How about, instead:
Signed-off-by: Pravin B Shelar
---
lib/netdev-linux.c | 85 ++--
1 files changed, 49 insertions(+), 36 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 3067953..c7991ac 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux
