[ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-18 Thread Romain Lenglet
Signed-off-by: Romain Lenglet --- ofproto/automake.mk | 2 + ofproto/ofproto-dpif-ipfix.c | 126 +++ ofproto/ofproto-dpif-ipfix.h | 28 ++ ofproto/ofproto-dpif.c | 25 + ofproto/ofproto-provider.h | 8 +++ ofproto/ofpr

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-18 Thread Romain Lenglet
On Jan 17, 2013, at 4:08 PM, Jesse Gross wrote: > On Thu, Jan 17, 2013 at 3:07 PM, Ben Pfaff wrote: >> On Thu, Jan 17, 2013 at 03:00:20PM -0800, Jesse Gross wrote: >>> On Thu, Jan 17, 2013 at 2:49 PM, Ben Pfaff wrote: On Thu, Jan 17, 2013 at 02:19:45PM -0800, Ben Pfaff wrote: > On Fri,

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-18 Thread Romain Lenglet
On Jan 17, 2013, at 2:19 PM, Ben Pfaff wrote: > On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrote: >> Signed-off-by: Romain Lenglet > > The schema limits each bridge to at most one IPFIX collector. Is > there an a priori reason why this is limited? It seems to me that one > could

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-17 Thread Ben Pfaff
On Thu, Jan 17, 2013 at 04:08:34PM -0800, Jesse Gross wrote: > On Thu, Jan 17, 2013 at 3:07 PM, Ben Pfaff wrote: > > On Thu, Jan 17, 2013 at 03:00:20PM -0800, Jesse Gross wrote: > >> On Thu, Jan 17, 2013 at 2:49 PM, Ben Pfaff wrote: > >> > On Thu, Jan 17, 2013 at 02:19:45PM -0800, Ben Pfaff wrote

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-17 Thread Jesse Gross
On Thu, Jan 17, 2013 at 3:07 PM, Ben Pfaff wrote: > On Thu, Jan 17, 2013 at 03:00:20PM -0800, Jesse Gross wrote: >> On Thu, Jan 17, 2013 at 2:49 PM, Ben Pfaff wrote: >> > On Thu, Jan 17, 2013 at 02:19:45PM -0800, Ben Pfaff wrote: >> >> On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrot

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-17 Thread Ben Pfaff
On Thu, Jan 17, 2013 at 03:00:20PM -0800, Jesse Gross wrote: > On Thu, Jan 17, 2013 at 2:49 PM, Ben Pfaff wrote: > > On Thu, Jan 17, 2013 at 02:19:45PM -0800, Ben Pfaff wrote: > >> On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrote: > > One more thing. sFlow and NetFlow configuration

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-17 Thread Jesse Gross
On Thu, Jan 17, 2013 at 2:49 PM, Ben Pfaff wrote: > On Thu, Jan 17, 2013 at 02:19:45PM -0800, Ben Pfaff wrote: >> On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrote: >> > Signed-off-by: Romain Lenglet >> >> The schema limits each bridge to at most one IPFIX collector. Is >> there an

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-17 Thread Ben Pfaff
On Thu, Jan 17, 2013 at 02:19:45PM -0800, Ben Pfaff wrote: > On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrote: > > Signed-off-by: Romain Lenglet > > The schema limits each bridge to at most one IPFIX collector. Is > there an a priori reason why this is limited? It seems to me that

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-17 Thread Ben Pfaff
On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrote: > Signed-off-by: Romain Lenglet The schema limits each bridge to at most one IPFIX collector. Is there an a priori reason why this is limited? It seems to me that one could want to send some samples to one set of collectors and oth

[ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-11 Thread Romain Lenglet
Signed-off-by: Romain Lenglet --- ofproto/automake.mk | 2 + ofproto/ofproto-dpif-ipfix.c | 126 +++ ofproto/ofproto-dpif-ipfix.h | 28 ++ ofproto/ofproto-dpif.c | 25 + ofproto/ofproto-provider.h | 8 +++ ofproto/ofpr

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-04 Thread Ben Pfaff
On Fri, Jan 04, 2013 at 12:39:40PM -0800, Romain Lenglet wrote: > On Jan 4, 2013, at 10:31 AM, Ben Pfaff wrote: > > >> +return di; > >> +} > > > > In vswitch.ovsschema, I believe that we could limit obs_domain_id to the > > 32-bit range, since it's a 32-bit value. Is it worthwhile to do so?

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-04 Thread Romain Lenglet
On Jan 4, 2013, at 10:31 AM, Ben Pfaff wrote: >> +return di; >> +} > > In vswitch.ovsschema, I believe that we could limit obs_domain_id to the > 32-bit range, since it's a 32-bit value. Is it worthwhile to do so? Good idea. I've done that, and done the changes you suggested for the other

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-04 Thread Ben Pfaff
On Tue, Dec 18, 2012 at 11:52:11AM -0800, Romain Lenglet wrote: > Signed-off-by: Romain Lenglet ... > +struct dpif_ipfix * > +dpif_ipfix_create(void) > +{ > +struct dpif_ipfix *di; > +di = xcalloc(1, sizeof *di); You can use xzalloc(x) instead of xcalloc(1, x); > +return di; > +}

[ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2012-12-18 Thread Romain Lenglet
Signed-off-by: Romain Lenglet --- ofproto/automake.mk | 2 + ofproto/ofproto-dpif-ipfix.c | 125 +++ ofproto/ofproto-dpif-ipfix.h | 28 ++ ofproto/ofproto-dpif.c | 25 + ofproto/ofproto-provider.h | 8 +++ ofproto/ofpr