Re: [ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

2016-03-07 Thread Joe Stringer
On 5 March 2016 at 13:25, Ben Pfaff wrote: > On Thu, Mar 03, 2016 at 09:22:50PM +1300, Joe Stringer wrote: >> When decoding a variable-length action, if the length of the action >> exceeds the length storable in a uint16_t then something has gone >> terribly wrong. Assert that this is not the case

Re: [ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

2016-03-05 Thread Ben Pfaff
On Thu, Mar 03, 2016 at 09:22:50PM +1300, Joe Stringer wrote: > When decoding a variable-length action, if the length of the action > exceeds the length storable in a uint16_t then something has gone > terribly wrong. Assert that this is not the case. > > Signed-off-by: Joe Stringer > --- > lib/

Re: [ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

2016-03-03 Thread Joe Stringer
On 3 March 2016 at 00:22, Joe Stringer wrote: > When decoding a variable-length action, if the length of the action > exceeds the length storable in a uint16_t then something has gone > terribly wrong. Assert that this is not the case. > > Signed-off-by: Joe Stringer With Jarno's ack from patch

[ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

2016-03-03 Thread Joe Stringer
When decoding a variable-length action, if the length of the action exceeds the length storable in a uint16_t then something has gone terribly wrong. Assert that this is not the case. Signed-off-by: Joe Stringer --- lib/ofp-actions.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) di