Re: [ovs-dev] [PATCH 3/4] meta-flow: Add VLAN VID as a prerequsite for VLAN PCP

2012-07-04 Thread Simon Horman
On Wed, Jul 04, 2012 at 03:06:25PM -0700, Ben Pfaff wrote: > On Wed, Jul 04, 2012 at 05:50:43PM +0900, Simon Horman wrote: > > Signed-off-by: Simon Horman > > This seems reasonable. > > I believe that we can test the behavior here by adding a few more lines > to the "ovs-ofctl parse-nxm" and "ov

Re: [ovs-dev] [PATCH 3/4] meta-flow: Add VLAN VID as a prerequsite for VLAN PCP

2012-07-04 Thread Ben Pfaff
On Wed, Jul 04, 2012 at 05:50:43PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman This seems reasonable. I believe that we can test the behavior here by adding a few more lines to the "ovs-ofctl parse-nxm" and "ovs-ofctl parse-oxm" tests in tests/ovs-ofctl.at. If you do that to valida

[ovs-dev] [PATCH 3/4] meta-flow: Add VLAN VID as a prerequsite for VLAN PCP

2012-07-04 Thread Simon Horman
Signed-off-by: Simon Horman --- lib/meta-flow.c | 8 +--- lib/meta-flow.h | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 72ed108..a8b296a 100644 --- a/lib/meta-flow.c +++ b/lib/meta-flow.c @@ -149,9 +149,9 @@ static const struct m