Re: [ovs-dev] [PATCH 3/3] xenserver: New iface-status external id.

2011-06-17 Thread Ethan Jackson
Cool, i'll go ahead and merge. Thanks for the reviews. Ethan On Fri, Jun 17, 2011 at 11:47, Ben Pfaff wrote: > On Fri, Jun 17, 2011 at 11:33:33AM -0700, Ethan Jackson wrote: >> > I think that update_iface() will now always call into ovs-vsctl to set >> > the iface-status. ?I think that it shoul

Re: [ovs-dev] [PATCH 3/3] xenserver: New iface-status external id.

2011-06-17 Thread Ben Pfaff
On Fri, Jun 17, 2011 at 11:33:33AM -0700, Ethan Jackson wrote: > > I think that update_iface() will now always call into ovs-vsctl to set > > the iface-status. ?I think that it should only do it if it needs to > > change, as we do for iface-id. > > update_iface() is only called on a given interfac

Re: [ovs-dev] [PATCH 3/3] xenserver: New iface-status external id.

2011-06-17 Thread Ethan Jackson
> I think that update_iface() will now always call into ovs-vsctl to set > the iface-status.  I think that it should only do it if it needs to > change, as we do for iface-id. update_iface() is only called on a given interface when there is a change in it's xs-vif-uuid, iface-id, or iface-status.

Re: [ovs-dev] [PATCH 3/3] xenserver: New iface-status external id.

2011-06-17 Thread Ben Pfaff
On Thu, Jun 16, 2011 at 05:15:15PM -0700, Ethan Jackson wrote: > The iface-status external id indicates to a controller which device > it should manage when there are multiple choices for a given vif. > Currently, it always chooses a tap device if available, but one > could imagine more sophisticat

[ovs-dev] [PATCH 3/3] xenserver: New iface-status external id.

2011-06-16 Thread Ethan Jackson
The iface-status external id indicates to a controller which device it should manage when there are multiple choices for a given vif. Currently, it always chooses a tap device if available, but one could imagine more sophisticated strategies in the future. Signed-off-by: Ethan Jackson --- .../us