Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-20 Thread Simon Horman
On Thu, Jul 19, 2012 at 09:51:29PM -0700, Ben Pfaff wrote: > On Fri, Jul 20, 2012 at 01:47:09PM +0900, Simon Horman wrote: > > Thanks, that helps a lot. > > > > I will see about implementing the OF1.2 version of these tests and > > fix my implementation as needed. > > Awesome. If, after consider

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 02:12:29PM +0900, Simon Horman wrote: > On Thu, Jul 19, 2012 at 10:08:47PM -0700, Ben Pfaff wrote: > > On Fri, Jul 20, 2012 at 02:06:31PM +0900, Simon Horman wrote: > > > On Thu, Jul 19, 2012 at 09:51:29PM -0700, Ben Pfaff wrote: > > > > On Fri, Jul 20, 2012 at 01:47:09PM +0

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Simon Horman
On Thu, Jul 19, 2012 at 10:08:47PM -0700, Ben Pfaff wrote: > On Fri, Jul 20, 2012 at 02:06:31PM +0900, Simon Horman wrote: > > On Thu, Jul 19, 2012 at 09:51:29PM -0700, Ben Pfaff wrote: > > > On Fri, Jul 20, 2012 at 01:47:09PM +0900, Simon Horman wrote: > > > > Thanks, that helps a lot. > > > > >

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 02:06:31PM +0900, Simon Horman wrote: > On Thu, Jul 19, 2012 at 09:51:29PM -0700, Ben Pfaff wrote: > > On Fri, Jul 20, 2012 at 01:47:09PM +0900, Simon Horman wrote: > > > Thanks, that helps a lot. > > > > > > I will see about implementing the OF1.2 version of these tests an

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Simon Horman
On Thu, Jul 19, 2012 at 09:51:29PM -0700, Ben Pfaff wrote: > On Fri, Jul 20, 2012 at 01:47:09PM +0900, Simon Horman wrote: > > Thanks, that helps a lot. > > > > I will see about implementing the OF1.2 version of these tests and > > fix my implementation as needed. > > Awesome. If, after consider

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 01:47:09PM +0900, Simon Horman wrote: > Thanks, that helps a lot. > > I will see about implementing the OF1.2 version of these tests and > fix my implementation as needed. Awesome. If, after consideration, something seems wrong, then let's revisit it.

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Simon Horman
On Thu, Jul 19, 2012 at 08:26:53PM -0700, Ben Pfaff wrote: > OK, there seem to be only two remaining points of disagreement. Let's > try to settle them. > > On Fri, Jul 20, 2012 at 08:22:27AM +0900, Simon Horman wrote: > > On Thu, Jul 19, 2012 at 10:44:18AM -0700, Ben Pfaff wrote: > > > On Thu, J

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Ben Pfaff
OK, there seem to be only two remaining points of disagreement. Let's try to settle them. On Fri, Jul 20, 2012 at 08:22:27AM +0900, Simon Horman wrote: > On Thu, Jul 19, 2012 at 10:44:18AM -0700, Ben Pfaff wrote: > > On Thu, Jul 19, 2012 at 05:56:01PM +0900, Simon Horman wrote: > > > On Thu, Jul

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Simon Horman
On Thu, Jul 19, 2012 at 10:44:18AM -0700, Ben Pfaff wrote: > On Thu, Jul 19, 2012 at 05:56:01PM +0900, Simon Horman wrote: > > On Thu, Jul 19, 2012 at 12:24:13AM -0700, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > > --- > > > DESIGN| 106 > > >

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Ben Pfaff
On Thu, Jul 19, 2012 at 05:56:01PM +0900, Simon Horman wrote: > On Thu, Jul 19, 2012 at 12:24:13AM -0700, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > DESIGN| 106 > > + > > tests/ovs-ofctl.at| 87 +++

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Simon Horman
On Thu, Jul 19, 2012 at 12:24:13AM -0700, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > DESIGN| 106 > + > tests/ovs-ofctl.at| 87 > utilities/ovs-ofctl.c | 76

[ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-19 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- DESIGN| 106 + tests/ovs-ofctl.at| 87 utilities/ovs-ofctl.c | 76 +++ 3 files changed, 269 insertions(+), 0 deletions(-)