Re: [ovs-dev] [PATCH 3/3] odp-util: Simplify logic in odp_flow_key_to_flow__().

2013-12-31 Thread Ben Pfaff
Thanks, I'll apply this in a moment. On Tue, Dec 31, 2013 at 11:41:52AM -0800, Andy Zhou wrote: > LGTM. > > > On Tue, Dec 31, 2013 at 10:45 AM, Ben Pfaff wrote: > > > Simplify (a && b) || (!a && c) to just a ? b : c. > > > > Signed-off-by: Ben Pfaff > > --- > > lib/odp-util.c |5 +++-- >

Re: [ovs-dev] [PATCH 3/3] odp-util: Simplify logic in odp_flow_key_to_flow__().

2013-12-31 Thread Andy Zhou
LGTM. On Tue, Dec 31, 2013 at 10:45 AM, Ben Pfaff wrote: > Simplify (a && b) || (!a && c) to just a ? b : c. > > Signed-off-by: Ben Pfaff > --- > lib/odp-util.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/odp-util.c b/lib/odp-util.c > index 3227e69..af

[ovs-dev] [PATCH 3/3] odp-util: Simplify logic in odp_flow_key_to_flow__().

2013-12-31 Thread Ben Pfaff
Simplify (a && b) || (!a && c) to just a ? b : c. Signed-off-by: Ben Pfaff --- lib/odp-util.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index 3227e69..aff6c95 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -3144,8 +3144,9 @@