Re: [ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

2014-05-06 Thread Ryan Wilson
Hey Joe, This looks good to me and fixes the root cause which is even better. I'm fairly new to OVS, so my ack likely doesn't mean much :) Ryan Wilson Member of Technical Staff wr...@vmware.com 3401 Hillview Avenue, Palo Alto, CA 650.427.1511 Office 916.588.7783 Mobile On May 5, 2014, at 8:16 P

Re: [ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

2014-05-05 Thread Joe Stringer
Thanks for taking a look Ryan. That sounds exactly like the issue I encountered. Looking at your assessment made me take a look at it again, and I found a much better solution. Do you mind taking a look at that one? http://openvswitch.org/pipermail/dev/2014-May/039790.html On 6 May 2014 09:18,

Re: [ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

2014-05-05 Thread Ryan Wilson
I've seen this issue before as well when adding RCU locking to xlate. It happens because refs to a netdev still exist (in this case, likely the tunnel has a ref to the netdev) when the main thread tries to delete the netdev. Thus, the netdev never gets deleted and the netdev cannot be recreated

Re: [ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

2014-05-04 Thread Joe Stringer
On 3 May 2014 02:56, Ben Pfaff wrote: > On Fri, May 02, 2014 at 01:13:43PM +1200, Joe Stringer wrote: > > Previously, it was possible to open a netdevice as one type, then > > proceed to open it as a different type without first closing it. The > > bridge code would expect it to be opened as the

Re: [ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

2014-05-02 Thread Ben Pfaff
On Fri, May 02, 2014 at 01:13:43PM +1200, Joe Stringer wrote: > Previously, it was possible to open a netdevice as one type, then > proceed to open it as a different type without first closing it. The > bridge code would expect it to be opened as the latter type and try to > apply configuration to

[ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

2014-05-01 Thread Joe Stringer
Previously, it was possible to open a netdevice as one type, then proceed to open it as a different type without first closing it. The bridge code would expect it to be opened as the latter type and try to apply configuration to it. This patch catches the problem earlier by detecting the case in ne