Re: [ovs-dev] [PATCH 3/3] dpctl: Add 'get-flow' command.

2014-12-18 Thread Andy Zhou
Consider that patch acked as well. It is trivially correct. On Thu, Dec 18, 2014 at 5:06 PM, Joe Stringer wrote: > On 18 December 2014 at 16:17, Andy Zhou wrote: >> Looks good. >> Acked-by: Andy Zhou > > Thanks, > >> Is it worth while to add a unit test for this? > > Can do, this would also dep

Re: [ovs-dev] [PATCH 3/3] dpctl: Add 'get-flow' command.

2014-12-18 Thread Joe Stringer
On 18 December 2014 at 16:17, Andy Zhou wrote: > Looks good. > Acked-by: Andy Zhou Thanks, > Is it worth while to add a unit test for this? Can do, this would also depend on the following patch: http://openvswitch.org/pipermail/dev/2014-December/049739.html

Re: [ovs-dev] [PATCH 3/3] dpctl: Add 'get-flow' command.

2014-12-18 Thread Andy Zhou
Looks good. Acked-by: Andy Zhou Is it worth while to add a unit test for this? On Wed, Dec 17, 2014 at 10:34 AM, Joe Stringer wrote: > This allows users to fetch a flow by giving a particular UFID. > > Usage: 'ovs-dpctl get-flow ufid:' > > Signed-off-by: Joe Stringer > --- > lib/dpctl.c

[ovs-dev] [PATCH 3/3] dpctl: Add 'get-flow' command.

2014-12-17 Thread Joe Stringer
This allows users to fetch a flow by giving a particular UFID. Usage: 'ovs-dpctl get-flow ufid:' Signed-off-by: Joe Stringer --- lib/dpctl.c | 96 + lib/dpctl.man |4 +++ utilities/ovs-dpctl.c |1 + 3 files changed, 86