Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-17 Thread Simon Horman
On Tue, Mar 12, 2013 at 08:24:15AM -0700, Jesse Gross wrote: > On Tue, Mar 12, 2013 at 12:26 AM, Simon Horman wrote: > > On Mon, Mar 11, 2013 at 10:00:54AM -0700, Jesse Gross wrote: > >> On Mon, Mar 11, 2013 at 6:02 AM, Rajahalme, Jarno (NSN - FI/Espoo) > >> wrote: > >> > > >> > On Mar 9, 2013, a

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-12 Thread Jesse Gross
On Tue, Mar 12, 2013 at 12:26 AM, Simon Horman wrote: > On Mon, Mar 11, 2013 at 10:00:54AM -0700, Jesse Gross wrote: >> On Mon, Mar 11, 2013 at 6:02 AM, Rajahalme, Jarno (NSN - FI/Espoo) >> wrote: >> > >> > On Mar 9, 2013, at 16:54 , ext Simon Horman wrote: >> > >> >> It is not obvious to me how

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-12 Thread Simon Horman
On Mon, Mar 11, 2013 at 10:00:54AM -0700, Jesse Gross wrote: > On Mon, Mar 11, 2013 at 6:02 AM, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: > > > > On Mar 9, 2013, at 16:54 , ext Simon Horman wrote: > > > >> It is not obvious to me how the behaviour relating to get_priority() as > >> described abov

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-11 Thread Jesse Gross
On Mon, Mar 11, 2013 at 6:02 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Mar 9, 2013, at 16:54 , ext Simon Horman wrote: > >> It is not obvious to me how the behaviour relating to get_priority() as >> described above can sensibly be reconciled with a desire to preserve the >> order of acti

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-11 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Mar 9, 2013, at 16:54 , ext Simon Horman wrote: > It is not obvious to me how the behaviour relating to get_priority() as > described above can sensibly be reconciled with a desire to preserve the > order of actions. Or even reconciled with a looser constraint that actions > that need l3+ data

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-11 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Mar 9, 2013, at 16:54 , ext Simon Horman wrote: > On Thu, Mar 07, 2013 at 11:12:31AM -0800, Ben Pfaff wrote: >> On Thu, Mar 07, 2013 at 04:12:22AM +0100, Simon Horman wrote: >>> Perhaps Ben has some ideas, but it seems to me that the >>> way that execute_* and compose_* interact needs to be ch

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-09 Thread Simon Horman
On Thu, Mar 07, 2013 at 11:12:31AM -0800, Ben Pfaff wrote: > On Thu, Mar 07, 2013 at 04:12:22AM +0100, Simon Horman wrote: > > Perhaps Ben has some ideas, but it seems to me that the > > way that execute_* and compose_* interact needs to be changed > > around in order to preserve the order of actio

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-07 Thread Ben Pfaff
On Thu, Mar 07, 2013 at 04:12:22AM +0100, Simon Horman wrote: > Perhaps Ben has some ideas, but it seems to me that the > way that execute_* and compose_* interact needs to be changed > around in order to preserve the order of actions. This seems likely to be necessary. ___

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-07 Thread Simon Horman
On Wed, Mar 06, 2013 at 09:12:53AM -0800, Jesse Gross wrote: > On Tue, Mar 5, 2013 at 10:03 PM, Simon Horman wrote: > > On Tue, Mar 05, 2013 at 11:35:41AM -0800, Jesse Gross wrote: > >> On Tue, Mar 5, 2013 at 10:23 AM, Ben Pfaff wrote: > >> > On Thu, Feb 28, 2013 at 06:15:09PM +0900, Simon Horman

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-06 Thread Jesse Gross
On Tue, Mar 5, 2013 at 10:03 PM, Simon Horman wrote: > On Tue, Mar 05, 2013 at 11:35:41AM -0800, Jesse Gross wrote: >> On Tue, Mar 5, 2013 at 10:23 AM, Ben Pfaff wrote: >> > On Thu, Feb 28, 2013 at 06:15:09PM +0900, Simon Horman wrote: >> >> Allow datapath to recognize and extract MPLS labels int

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-05 Thread Simon Horman
On Tue, Mar 05, 2013 at 11:35:41AM -0800, Jesse Gross wrote: > On Tue, Mar 5, 2013 at 10:23 AM, Ben Pfaff wrote: > > On Thu, Feb 28, 2013 at 06:15:09PM +0900, Simon Horman wrote: > >> Allow datapath to recognize and extract MPLS labels into flow keys > >> and execute actions which push, pop, and s

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-05 Thread Ben Pfaff
On Tue, Mar 05, 2013 at 11:35:41AM -0800, Jesse Gross wrote: > On Tue, Mar 5, 2013 at 10:23 AM, Ben Pfaff wrote: > > On Thu, Feb 28, 2013 at 06:15:09PM +0900, Simon Horman wrote: > >> Allow datapath to recognize and extract MPLS labels into flow keys > >> and execute actions which push, pop, and s

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-05 Thread Jesse Gross
On Tue, Mar 5, 2013 at 10:23 AM, Ben Pfaff wrote: > On Thu, Feb 28, 2013 at 06:15:09PM +0900, Simon Horman wrote: >> Allow datapath to recognize and extract MPLS labels into flow keys >> and execute actions which push, pop, and set labels on packets. >> >> Based heavily on work by Leo Alterman and

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-05 Thread Ben Pfaff
On Thu, Feb 28, 2013 at 06:15:09PM +0900, Simon Horman wrote: > Allow datapath to recognize and extract MPLS labels into flow keys > and execute actions which push, pop, and set labels on packets. > > Based heavily on work by Leo Alterman and Ravi K. > > Cc: Ravi K > Cc: Leo Alterman > Reviewed

[ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-02-28 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- TODO: * Exercise check