Re: [ovs-dev] [PATCH 3/3] daemon: Move some common code to daemon.c

2014-04-24 Thread Ben Pfaff
On Thu, Apr 24, 2014 at 10:26:26AM -0700, Gurucharan Shetty wrote: > On Thu, Apr 24, 2014 at 9:26 AM, Ben Pfaff wrote: > > On Thu, Apr 24, 2014 at 08:31:04AM -0700, Gurucharan Shetty wrote: > >> We have some common code between daemon-unix.c and > >> daemon-windows.c. Move them to daemon.c > >> >

Re: [ovs-dev] [PATCH 3/3] daemon: Move some common code to daemon.c

2014-04-24 Thread Gurucharan Shetty
On Thu, Apr 24, 2014 at 9:26 AM, Ben Pfaff wrote: > On Thu, Apr 24, 2014 at 08:31:04AM -0700, Gurucharan Shetty wrote: >> We have some common code between daemon-unix.c and >> daemon-windows.c. Move them to daemon.c >> >> Signed-off-by: Gurucharan Shetty > > "sparse" reports: > > ../lib/daemo

Re: [ovs-dev] [PATCH 3/3] daemon: Move some common code to daemon.c

2014-04-24 Thread Ben Pfaff
On Thu, Apr 24, 2014 at 08:31:04AM -0700, Gurucharan Shetty wrote: > We have some common code between daemon-unix.c and > daemon-windows.c. Move them to daemon.c > > Signed-off-by: Gurucharan Shetty "sparse" reports: ../lib/daemon-unix.c:42:6: warning: symbol 'detach' was not declared. Sho

[ovs-dev] [PATCH 3/3] daemon: Move some common code to daemon.c

2014-04-24 Thread Gurucharan Shetty
We have some common code between daemon-unix.c and daemon-windows.c. Move them to daemon.c Signed-off-by: Gurucharan Shetty --- lib/daemon-unix.c| 37 +++-- lib/daemon-windows.c | 40 ++-- lib/daemon.c | 33 +++