Re: [ovs-dev] [PATCH 3/3] Allow util.h in libopenvswitch to be used by another library

2013-12-16 Thread Ben Pfaff
On Mon, Dec 16, 2013 at 10:26:15PM -0800, Harold Lim wrote: > ... that has already defined the NOT_REACHED macro > > Add an #ifndef guard around NOT_REACHED macro. How do we know that they are compatible? I don't think that this is a good idea. I'd be happy to rename NOT_REACHED to OVS_NOT_REAC

[ovs-dev] [PATCH 3/3] Allow util.h in libopenvswitch to be used by another library

2013-12-16 Thread Harold Lim
... that has already defined the NOT_REACHED macro Add an #ifndef guard around NOT_REACHED macro. --- lib/util.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/util.h b/lib/util.h index 462247b..1680cd6 100644 --- a/lib/util.h +++ b/lib/util.h @@ -150,7 +150,9 @@ is_pow2(uintmax_t x