Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-25 Thread Simon Horman
On Wed, Apr 25, 2012 at 08:57:16AM -0700, Ben Pfaff wrote: > On Wed, Apr 25, 2012 at 09:15:53AM +0900, Simon Horman wrote: > > I do have one other (minor) problem that I am facing which is the different > > widths of IN_PORT. 16 bits for NXM and 32 bits for OXM. > > > > Special casing this in the

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-25 Thread Ben Pfaff
On Wed, Apr 25, 2012 at 09:15:53AM +0900, Simon Horman wrote: > I do have one other (minor) problem that I am facing which is the different > widths of IN_PORT. 16 bits for NXM and 32 bits for OXM. > > Special casing this in the encoder isn't so bad, it basically encodes each > field individually.

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-24 Thread Simon Horman
On Tue, Apr 24, 2012 at 08:57:18AM -0700, Ben Pfaff wrote: > On Tue, Apr 24, 2012 at 10:02:25AM +0900, Simon Horman wrote: > > On Mon, Apr 23, 2012 at 08:34:45AM +0900, Simon Horman wrote: > > > On Fri, Apr 20, 2012 at 08:36:57AM -0700, Ben Pfaff wrote: > > > > On Fri, Apr 20, 2012 at 09:24:05AM +0

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-24 Thread Ben Pfaff
On Tue, Apr 24, 2012 at 10:11:39AM -0700, Justin Pettit wrote: > On Apr 24, 2012, at 8:57 AM, Ben Pfaff wrote: > > > Someone on the team here (Ansis?) is already working on > > OXM_OF_IPV6_FLABEL maskability because one of our customers has a use > > case. > > Actually, he's working on making NXM

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-24 Thread Justin Pettit
On Apr 24, 2012, at 8:57 AM, Ben Pfaff wrote: > Someone on the team here (Ansis?) is already working on > OXM_OF_IPV6_FLABEL maskability because one of our customers has a use > case. Actually, he's working on making NXM_NX_ND_TARGET maskable. I don't know of any plans to make the flow label ma

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-24 Thread Ben Pfaff
On Tue, Apr 24, 2012 at 10:02:25AM +0900, Simon Horman wrote: > On Mon, Apr 23, 2012 at 08:34:45AM +0900, Simon Horman wrote: > > On Fri, Apr 20, 2012 at 08:36:57AM -0700, Ben Pfaff wrote: > > > On Fri, Apr 20, 2012 at 09:24:05AM +0900, Simon Horman wrote: > > > > This may be used in a similar way

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-23 Thread Simon Horman
On Mon, Apr 23, 2012 at 08:34:45AM +0900, Simon Horman wrote: > On Fri, Apr 20, 2012 at 08:36:57AM -0700, Ben Pfaff wrote: > > On Fri, Apr 20, 2012 at 09:24:05AM +0900, Simon Horman wrote: > > > This may be used in a similar way to nxm_mf_fields > > > to handle parsing and serialisation of OXM TLVs

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-22 Thread Simon Horman
On Fri, Apr 20, 2012 at 08:36:57AM -0700, Ben Pfaff wrote: > On Fri, Apr 20, 2012 at 09:24:05AM +0900, Simon Horman wrote: > > This may be used in a similar way to nxm_mf_fields > > to handle parsing and serialisation of OXM TLVs. > > > > Signed-off-by: Simon Horman > > My own thought for how to

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-20 Thread Ben Pfaff
On Fri, Apr 20, 2012 at 09:24:05AM +0900, Simon Horman wrote: > This may be used in a similar way to nxm_mf_fields > to handle parsing and serialisation of OXM TLVs. > > Signed-off-by: Simon Horman My own thought for how to do OXM was to just add a new 'oxm_header' member (and possibly 'oxm_name

[ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-19 Thread Simon Horman
This may be used in a similar way to nxm_mf_fields to handle parsing and serialisation of OXM TLVs. Signed-off-by: Simon Horman --- include/openflow/openflow-1.2.h |1 + lib/meta-flow.c | 404 +++ lib/meta-flow.h | 16 ++