Re: [ovs-dev] [PATCH 2/9] tunneling: Add check for GRE protocol is Ethernet.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross wrote: > On receive, the userspace GRE code doesn't check the protocol > field. Since OVS only understands Ethernet packets, this adds a > check that the inner protocol is Ethernet and discards other types > of packets. > > Signed-off-by: Jesse Gross A

Re: [ovs-dev] [PATCH 2/9] tunneling: Add check for GRE protocol is Ethernet.

2015-03-31 Thread Pritesh Kothari (pritkoth)
tested, LGTM, Thanks, appreciated. Acked-by: Pritesh Kothari > On Mar 30, 2015, at 9:38 PM, Jesse Gross wrote: > > It's probably a good idea although it requires a different type of > test compared with what we already have since the GRE protocol doesn't > appear in the flow. Here's what I cam

Re: [ovs-dev] [PATCH 2/9] tunneling: Add check for GRE protocol is Ethernet.

2015-03-30 Thread Jesse Gross
It's probably a good idea although it requires a different type of test compared with what we already have since the GRE protocol doesn't appear in the flow. Here's what I came up with: diff --git a/tests/tunnel-push-pop.at b/tests/tunnel-push-pop.at index 6e1c0c1..ee17a2f 100644 --- a/tests/tunne

Re: [ovs-dev] [PATCH 2/9] tunneling: Add check for GRE protocol is Ethernet.

2015-03-30 Thread Pritesh Kothari (pritkoth)
should a test case be added to catch this ? Regards, Pritesh > On Mar 30, 2015, at 3:14 PM, Jesse Gross wrote: > > +if (greh->protocol != htons(ETH_TYPE_TEB)) { > +return -EINVAL; > +} > + ___ dev mailing list dev@openvswitch.org http

[ovs-dev] [PATCH 2/9] tunneling: Add check for GRE protocol is Ethernet.

2015-03-30 Thread Jesse Gross
On receive, the userspace GRE code doesn't check the protocol field. Since OVS only understands Ethernet packets, this adds a check that the inner protocol is Ethernet and discards other types of packets. Signed-off-by: Jesse Gross --- lib/netdev-vport.c | 4 1 file changed, 4 insertions(+)