Re: [ovs-dev] [PATCH 2/9] ofp-actions: Add action bitmap abstraction.

2014-08-11 Thread Ben Pfaff
On Thu, Aug 07, 2014 at 04:03:21PM -0700, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > Three minor comments below, > > Jarno > > On Aug 4, 2014, at 9:21 AM, Ben Pfaff wrote: > > > Until now, sets of actions have been abstracted separately outside > > ofp-actions, as enum ofputil_a

Re: [ovs-dev] [PATCH 2/9] ofp-actions: Add action bitmap abstraction.

2014-08-07 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme Three minor comments below, Jarno On Aug 4, 2014, at 9:21 AM, Ben Pfaff wrote: > Until now, sets of actions have been abstracted separately outside > ofp-actions, as enum ofputil_action_bitmap. Drawing sets of actions into > ofp-actions, as done in this commit, ma

[ovs-dev] [PATCH 2/9] ofp-actions: Add action bitmap abstraction.

2014-08-04 Thread Ben Pfaff
Until now, sets of actions have been abstracted separately outside ofp-actions, as enum ofputil_action_bitmap. Drawing sets of actions into ofp-actions, as done in this commit, makes for a better overall abstraction of actions, with better consistency. A big part of this commit is shifting from u