Re: [ovs-dev] [PATCH 2/8] ofproto-dpif: Guard rule statistics with a mutex.

2013-08-05 Thread Ethan Jackson
Good point, I made the change. Ethan On Mon, Aug 5, 2013 at 11:29 AM, Ben Pfaff wrote: > On Sat, Aug 03, 2013 at 06:42:04PM -0700, Ethan Jackson wrote: >> Signed-off-by: Ethan Jackson > > In rule_destruct(), I think it would be better to destroy the mutex > following complete_operation(). Who

Re: [ovs-dev] [PATCH 2/8] ofproto-dpif: Guard rule statistics with a mutex.

2013-08-05 Thread Ben Pfaff
On Sat, Aug 03, 2013 at 06:42:04PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson In rule_destruct(), I think it would be better to destroy the mutex following complete_operation(). Who knows, that function might want to eventually look at the statistics. Acked-by: Ben Pfaff __

[ovs-dev] [PATCH 2/8] ofproto-dpif: Guard rule statistics with a mutex.

2013-08-03 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif.c | 13 +++-- ofproto/ofproto-dpif.h |6 -- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 1d3f4ca..439adf7 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofpr