Re: [ovs-dev] [PATCH 2/7] datapath: Eliminate memset() from flow_extract.

2014-06-19 Thread Pravin Shelar
On Thu, Jun 19, 2014 at 2:54 PM, Jesse Gross wrote: > On Thu, Jun 19, 2014 at 2:01 PM, Pravin Shelar wrote: >> On Thu, Jun 19, 2014 at 1:46 PM, Jesse Gross wrote: >>> On Thu, Jun 19, 2014 at 1:30 PM, Pravin Shelar wrote: On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote: > @@ -520,18

Re: [ovs-dev] [PATCH 2/7] datapath: Eliminate memset() from flow_extract.

2014-06-19 Thread Jesse Gross
On Thu, Jun 19, 2014 at 2:01 PM, Pravin Shelar wrote: > On Thu, Jun 19, 2014 at 1:46 PM, Jesse Gross wrote: >> On Thu, Jun 19, 2014 at 1:30 PM, Pravin Shelar wrote: >>> On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote: @@ -520,18 +534,24 @@ int ovs_flow_extract(struct sk_buff *skb, u16

Re: [ovs-dev] [PATCH 2/7] datapath: Eliminate memset() from flow_extract.

2014-06-19 Thread Pravin Shelar
On Thu, Jun 19, 2014 at 1:46 PM, Jesse Gross wrote: > On Thu, Jun 19, 2014 at 1:30 PM, Pravin Shelar wrote: >> On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote: >>> As new protocols are added, the size of the flow key tends to >>> increase although few protocols care about all of the fields. I

Re: [ovs-dev] [PATCH 2/7] datapath: Eliminate memset() from flow_extract.

2014-06-19 Thread Jesse Gross
On Thu, Jun 19, 2014 at 1:30 PM, Pravin Shelar wrote: > On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote: >> As new protocols are added, the size of the flow key tends to >> increase although few protocols care about all of the fields. In >> order to optimize this for hashing and matching, OVS

Re: [ovs-dev] [PATCH 2/7] datapath: Eliminate memset() from flow_extract.

2014-06-19 Thread Pravin Shelar
On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote: > As new protocols are added, the size of the flow key tends to > increase although few protocols care about all of the fields. In > order to optimize this for hashing and matching, OVS uses a varible > length portion of the key. However, when fi

Re: [ovs-dev] [PATCH 2/7] datapath: Eliminate memset() from flow_extract.

2014-06-11 Thread Thomas Graf
On 06/10/14 at 04:47pm, Jesse Gross wrote: > As new protocols are added, the size of the flow key tends to > increase although few protocols care about all of the fields. In > order to optimize this for hashing and matching, OVS uses a varible > length portion of the key. However, when fields are e

[ovs-dev] [PATCH 2/7] datapath: Eliminate memset() from flow_extract.

2014-06-10 Thread Jesse Gross
As new protocols are added, the size of the flow key tends to increase although few protocols care about all of the fields. In order to optimize this for hashing and matching, OVS uses a varible length portion of the key. However, when fields are extracted from the packet we must still zero out the