Re: [ovs-dev] [PATCH 2/5] upcall: Defer ukey deletion until after pushing stats.

2014-02-25 Thread Ben Pfaff
Yes, I moved it out of the function in the next patch. On Tue, Feb 25, 2014 at 04:06:11PM -0800, Joe Stringer wrote: > I suspect you may have found that the later patches make use of this > structure in more locations? > > Either way, fine by me. > > > On 25 February 2014 15:16, Ben Pfaff wrot

Re: [ovs-dev] [PATCH 2/5] upcall: Defer ukey deletion until after pushing stats.

2014-02-25 Thread Joe Stringer
I suspect you may have found that the later patches make use of this structure in more locations? Either way, fine by me. On 25 February 2014 15:16, Ben Pfaff wrote: > On Tue, Feb 11, 2014 at 01:55:33PM -0800, Joe Stringer wrote: > > It is possible for a datapath to dump the same flow twice, f

Re: [ovs-dev] [PATCH 2/5] upcall: Defer ukey deletion until after pushing stats.

2014-02-25 Thread Ben Pfaff
On Tue, Feb 11, 2014 at 01:55:33PM -0800, Joe Stringer wrote: > It is possible for a datapath to dump the same flow twice, for instance > if the flow is the last in a batch of flows to be dumped, then a new > flow is inserted into the same bucket before the flow dumper fetches > another batch. > >

[ovs-dev] [PATCH 2/5] upcall: Defer ukey deletion until after pushing stats.

2014-02-11 Thread Joe Stringer
It is possible for a datapath to dump the same flow twice, for instance if the flow is the last in a batch of flows to be dumped, then a new flow is inserted into the same bucket before the flow dumper fetches another batch. In this case, datapath flow stats may be duplicated: The revalidator reco