Re: [ovs-dev] [PATCH 2/5] system-common-macros: Don't use bash to exec in ns.

2015-08-11 Thread Joe Stringer
This looks like a reasonable solution, I'll have a play around with it. On 11 August 2015 at 05:25, Daniele Di Proietto wrote: > I'm not an autoconf expert, but having NS_CHECK_EXEC and > NS_CHECK_EXEC_UNQUOTED for this purpose might be confusing, since > there already are AT_CHECK and AT_CHECK_U

Re: [ovs-dev] [PATCH 2/5] system-common-macros: Don't use bash to exec in ns.

2015-08-11 Thread Daniele Di Proietto
I'm not an autoconf expert, but having NS_CHECK_EXEC and NS_CHECK_EXEC_UNQUOTED for this purpose might be confusing, since there already are AT_CHECK and AT_CHECK_UNQUOTED, and the "UNQUOTED" refers to comparison text. How about this? # NS_EXEC([namespace], [command]) # # Execute 'command' in 'na

Re: [ovs-dev] [PATCH 2/5] system-common-macros: Don't use bash to exec in ns.

2015-08-10 Thread Joe Stringer
Hmm. The problem I was having is that if we wrap 'command' in quotes here, and 'command' itself includes quotes (eg, command='echo "foo" | bar'), then rather than quoting "foo", the command ends up quoting everything up to 'foo', then unquoting 'foo', then quoting everything after 'foo'. The ICMP r

Re: [ovs-dev] [PATCH 2/5] system-common-macros: Don't use bash to exec in ns.

2015-08-10 Thread Daniele Di Proietto
I guess you need this to use quotes("") inside 'command'. One effect of this change is that if 'command' contains a pipe (or &&, or ||) just the first command will be executed inside the namespace. I'm not sure if it's a big problem. What do you think? On 08/08/2015 00:28, "Joe Stringer" wrote

[ovs-dev] [PATCH 2/5] system-common-macros: Don't use bash to exec in ns.

2015-08-07 Thread Joe Stringer
ip netns exec $namespace $command doesn't need to use bash to execute the command. Remove it. Signed-off-by: Joe Stringer --- tests/system-common-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 1321