Re: [ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-24 Thread Alexandru Copot
On Sun, Mar 23, 2014 at 11:58 PM, Ben Pfaff wrote: > I decided that the best thing to do here was to do it myself, so I > committed your patch 1/5 (with a few adjustments) followed by a patch > that disables OF1.4 unless one specifies --enable-of14 on the > ovs-vswitchd command line. This should

Re: [ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-23 Thread Ben Pfaff
On Fri, Mar 21, 2014 at 09:17:28AM -0700, Ben Pfaff wrote: > On Fri, Mar 21, 2014 at 10:50:24AM +0200, Alexandru Copot wrote: > > On Tue, Mar 18, 2014 at 12:07 AM, Ben Pfaff wrote: > > >> > > > >> > The one bit that I'm concerned about is that it allows OpenFlow 1.4 to > > >> > be enabled even tho

Re: [ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-21 Thread Ben Pfaff
On Fri, Mar 21, 2014 at 10:50:24AM +0200, Alexandru Copot wrote: > On Tue, Mar 18, 2014 at 12:07 AM, Ben Pfaff wrote: > >> > > >> > The one bit that I'm concerned about is that it allows OpenFlow 1.4 to > >> > be enabled even though there are unimplemented messages that will cause > >> > Open vSwi

Re: [ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-21 Thread Alexandru Copot
On Tue, Mar 18, 2014 at 12:07 AM, Ben Pfaff wrote: >> > >> > The one bit that I'm concerned about is that it allows OpenFlow 1.4 to >> > be enabled even though there are unimplemented messages that will cause >> > Open vSwitch to abort if ovs-vswitchd receives one. >> >> This was my concern too af

Re: [ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-17 Thread Ben Pfaff
On Mon, Mar 17, 2014 at 10:39:01AM +0200, Alexandru Copot wrote: > On Mon, Mar 17, 2014 at 7:08 AM, Ben Pfaff wrote: > > On Mon, Mar 03, 2014 at 03:22:32PM +0200, Alexandru Copot wrote: > >> This defines the version number for OpenFlow 1.4 so that the switch > >> can actually use it. The ovsdb sch

Re: [ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-17 Thread Alexandru Copot
On Mon, Mar 17, 2014 at 7:08 AM, Ben Pfaff wrote: > On Mon, Mar 03, 2014 at 03:22:32PM +0200, Alexandru Copot wrote: >> This defines the version number for OpenFlow 1.4 so that the switch >> can actually use it. The ovsdb schema is also modified. >> >> Signed-off-by: Alexandru Copot >> Cc: Daniel

Re: [ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-16 Thread Ben Pfaff
On Mon, Mar 03, 2014 at 03:22:32PM +0200, Alexandru Copot wrote: > This defines the version number for OpenFlow 1.4 so that the switch > can actually use it. The ovsdb schema is also modified. > > Signed-off-by: Alexandru Copot > Cc: Daniel Baluta I'm pretty happy with this. The one bit that I

[ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-03 Thread Alexandru Copot
This defines the version number for OpenFlow 1.4 so that the switch can actually use it. The ovsdb schema is also modified. Signed-off-by: Alexandru Copot Cc: Daniel Baluta --- build-aux/extract-ofp-errors | 3 +- build-aux/extract-ofp-msgs | 8 +-- include/openflow/openflow-c