Re: [ovs-dev] [PATCH 2/5] flow: Add flow_mask_unwildcard_all()

2014-04-03 Thread Jarno Rajahalme
On Apr 3, 2014, at 11:52 AM, Ben Pfaff wrote: > On Thu, Mar 27, 2014 at 09:44:26AM -0700, Pravin wrote: >> This function will be used by later commit. >> >> Signed-off-by: Pravin B Shelar > > The code seems fine, but I really don't like this term "unwildcard" > we've invented, so I'm trying t

Re: [ovs-dev] [PATCH 2/5] flow: Add flow_mask_unwildcard_all()

2014-04-03 Thread Ben Pfaff
On Thu, Mar 27, 2014 at 09:44:26AM -0700, Pravin wrote: > This function will be used by later commit. > > Signed-off-by: Pravin B Shelar The code seems fine, but I really don't like this term "unwildcard" we've invented, so I'm trying to reduce the use of it. How about just "match" instead of "

[ovs-dev] [PATCH 2/5] flow: Add flow_mask_unwildcard_all()

2014-03-27 Thread Pravin
This function will be used by later commit. Signed-off-by: Pravin B Shelar --- lib/dpif-netdev.c | 16 +--- lib/meta-flow.c | 20 lib/meta-flow.h |1 + 3 files changed, 22 insertions(+), 15 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netde