Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-22 Thread Jesse Gross
On Thu, Sep 22, 2011 at 1:58 PM, Ben Pfaff wrote: > On Thu, Sep 22, 2011 at 01:50:26PM -0700, Jesse Gross wrote: >> On Thu, Sep 22, 2011 at 11:33 AM, Ben Pfaff wrote: >> > In find_dpif(), as a micro-optimization you could use >> > HMAP_FOR_EACH_IN_BUCKET in place of HMAP_FOR_EACH_WITH_HASH. >> >>

Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-22 Thread Ben Pfaff
On Thu, Sep 22, 2011 at 01:50:26PM -0700, Jesse Gross wrote: > On Thu, Sep 22, 2011 at 11:33 AM, Ben Pfaff wrote: > > In find_dpif(), as a micro-optimization you could use > > HMAP_FOR_EACH_IN_BUCKET in place of HMAP_FOR_EACH_WITH_HASH. > > You mean because comparing the ifindex is just as cheap

Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-22 Thread Jesse Gross
On Thu, Sep 22, 2011 at 11:33 AM, Ben Pfaff wrote: > On Mon, Sep 19, 2011 at 03:00:05PM -0700, Jesse Gross wrote: >> Currently we publish several multicast groups for upcalls and let >> userspace sockets subscribe to them.  The benefit of this is mostly >> that userspace is the one doing the subsc

Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-22 Thread Ben Pfaff
On Wed, Sep 21, 2011 at 10:43:48PM -0700, Jesse Gross wrote: > On Wed, Sep 21, 2011 at 10:28 PM, Ben Pfaff wrote: > > On Mon, Sep 19, 2011 at 03:00:05PM -0700, Jesse Gross wrote: > >> Currently we publish several multicast groups for upcalls and let > >> userspace sockets subscribe to them. ??The

Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-22 Thread Ben Pfaff
On Mon, Sep 19, 2011 at 03:00:05PM -0700, Jesse Gross wrote: > Currently we publish several multicast groups for upcalls and let > userspace sockets subscribe to them. The benefit of this is mostly > that userspace is the one doing the subscription - the actual > multicast capability is not curren

Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-21 Thread Jesse Gross
On Wed, Sep 21, 2011 at 10:28 PM, Ben Pfaff wrote: > On Mon, Sep 19, 2011 at 03:00:05PM -0700, Jesse Gross wrote: >> Currently we publish several multicast groups for upcalls and let >> userspace sockets subscribe to them.  The benefit of this is mostly >> that userspace is the one doing the subsc

Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-21 Thread Ben Pfaff
On Mon, Sep 19, 2011 at 03:00:05PM -0700, Jesse Gross wrote: > Currently we publish several multicast groups for upcalls and let > userspace sockets subscribe to them. The benefit of this is mostly > that userspace is the one doing the subscription - the actual > multicast capability is not curren

Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-20 Thread Jesse Gross
2011/9/19 Sébastien Riccio : > Hi, > Not really sure, but it seems this part of the patch is rejected against the > git master tree > > On 20.09.2011 00:00, Jesse Gross wrote: >> >>                        len += nla_total_size(upcall_info->actions_len); >> >>                user_skb = genlmsg_new(l

Re: [ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-19 Thread Sébastien Riccio
Hi, Not really sure, but it seems this part of the patch is rejected against the git master tree On 20.09.2011 00:00, Jesse Gross wrote: len += nla_total_size(upcall_info->actions_len); user_skb = genlmsg_new(len, GFP_ATOMIC); - if (!user_

[ovs-dev] [PATCH 2/5] datapath: Use unicast Netlink sockets for upcalls.

2011-09-19 Thread Jesse Gross
Currently we publish several multicast groups for upcalls and let userspace sockets subscribe to them. The benefit of this is mostly that userspace is the one doing the subscription - the actual multicast capability is not currently used and probably wouldn't be even if we moved to a multiprocess