Re: [ovs-dev] [PATCH 2/4] db-ctl-base: make cmd_show_table private

2015-07-17 Thread Andy Zhou
> We have an issue here. The 'show->recurse' is used to prevent dependency > loop in the users defined 'struct cmd_show_table' array. So, we cannot copy > the element here. > You are right. I will restructure this patch. Given that other patches in the series are acked. I will drop this patch,

Re: [ovs-dev] [PATCH 2/4] db-ctl-base: make cmd_show_table private

2015-07-16 Thread Alex Wang
On Mon, Jul 13, 2015 at 11:48 PM, Andy Zhou wrote: > Instead of require user to declare a global variable, pass the value > via ctl_init(). > > Signed-off-by: Andy Zhou > --- > lib/db-ctl-base.c | 34 +- > lib/db-ctl-base.h | 17 +++-- > utili

[ovs-dev] [PATCH 2/4] db-ctl-base: make cmd_show_table private

2015-07-13 Thread Andy Zhou
Instead of require user to declare a global variable, pass the value via ctl_init(). Signed-off-by: Andy Zhou --- lib/db-ctl-base.c | 34 +- lib/db-ctl-base.h | 17 +++-- utilities/ovs-vsctl.c | 4 ++-- vtep/vtep-ctl.c | 4 ++-- 4 files