Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-14 Thread Thomas Graf
On 04/14/2014 05:59 PM, Pravin Shelar wrote: On Mon, Apr 14, 2014 at 8:19 PM, Thomas Graf wrote: On 04/14/2014 08:54 AM, Pravin Shelar wrote: On Wed, Apr 9, 2014 at 4:05 PM, Thomas Graf wrote: I believe skb_get_hash() can be 0 and that would result in mistaking any empty slot to be a cache

Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-14 Thread Pravin Shelar
On Mon, Apr 14, 2014 at 8:19 PM, Thomas Graf wrote: > On 04/14/2014 08:54 AM, Pravin Shelar wrote: >> >> On Wed, Apr 9, 2014 at 4:05 PM, Thomas Graf wrote: >>> >>> I believe skb_get_hash() can be 0 and that would result in mistaking any >>> empty slot to be a cached entry and we would only look a

Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-14 Thread Thomas Graf
On 04/14/2014 08:54 AM, Pravin Shelar wrote: On Wed, Apr 9, 2014 at 4:05 PM, Thomas Graf wrote: I believe skb_get_hash() can be 0 and that would result in mistaking any empty slot to be a cached entry and we would only look at the first flow mask. software skb_get_hash() returns zero for erro

Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-14 Thread Pravin Shelar
On Wed, Apr 9, 2014 at 4:59 PM, Thomas Graf wrote: > On 04/08/2014 12:00 AM, Pravin wrote: >> >> +struct sw_flow *ovs_flow_tbl_lookup_stats(struct flow_table *tbl, >> + const struct sw_flow_key *key, >> + u32 skb_hash,

Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-13 Thread Pravin Shelar
On Wed, Apr 9, 2014 at 4:05 PM, Thomas Graf wrote: > On 04/08/2014 12:00 AM, Pravin wrote: >> >> From: Pravin Shelar >> >> On every packet OVS needs to lookup flow-table with every mask. >> the packet flow-key is first masked with mask in the list and >> then the masked key is looked up in flow-t

Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-09 Thread Thomas Graf
On 04/08/2014 12:00 AM, Pravin wrote: +struct sw_flow *ovs_flow_tbl_lookup_stats(struct flow_table *tbl, + const struct sw_flow_key *key, + u32 skb_hash, + u32 *n_mask_hit) +{ +

Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-09 Thread Thomas Graf
On 04/08/2014 12:00 AM, Pravin wrote: From: Pravin Shelar On every packet OVS needs to lookup flow-table with every mask. the packet flow-key is first masked with mask in the list and then the masked key is looked up in flow-table. Therefore number of masks can affect packet processing perform

[ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-07 Thread Pravin
From: Pravin Shelar On every packet OVS needs to lookup flow-table with every mask. the packet flow-key is first masked with mask in the list and then the masked key is looked up in flow-table. Therefore number of masks can affect packet processing performance. Following patch adds mask pointer