Re: [ovs-dev] [PATCH 2/3] kmod-macros: Don't unload kmod in VSWITCHD_STOP.

2015-08-07 Thread Joe Stringer
On 6 August 2015 at 18:37, Andy Zhou wrote: > On Thu, Aug 6, 2015 at 3:58 PM, Joe Stringer wrote: >> On 30 July 2015 at 12:51, Joe Stringer wrote: >>> On 30 July 2015 at 11:57, Andy Zhou wrote: On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote: > We already queue the removal o

Re: [ovs-dev] [PATCH 2/3] kmod-macros: Don't unload kmod in VSWITCHD_STOP.

2015-08-06 Thread Andy Zhou
On Thu, Aug 6, 2015 at 3:58 PM, Joe Stringer wrote: > On 30 July 2015 at 12:51, Joe Stringer wrote: >> On 30 July 2015 at 11:57, Andy Zhou wrote: >>> On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer >>> wrote: We already queue the removal of the kernel module in OVS_VSWITCHD_START, via

Re: [ovs-dev] [PATCH 2/3] kmod-macros: Don't unload kmod in VSWITCHD_STOP.

2015-08-06 Thread Joe Stringer
On 30 July 2015 at 12:51, Joe Stringer wrote: > On 30 July 2015 at 11:57, Andy Zhou wrote: >> On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote: >>> We already queue the removal of the kernel module in OVS_VSWITCHD_START, >>> via an ON_EXIT() call. This redundant removal also doesn't interact

Re: [ovs-dev] [PATCH 2/3] kmod-macros: Don't unload kmod in VSWITCHD_STOP.

2015-07-30 Thread Joe Stringer
On 30 July 2015 at 11:57, Andy Zhou wrote: > On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote: >> We already queue the removal of the kernel module in OVS_VSWITCHD_START, >> via an ON_EXIT() call. This redundant removal also doesn't interact very >> well with usage of vports: If the datapath s

Re: [ovs-dev] [PATCH 2/3] kmod-macros: Don't unload kmod in VSWITCHD_STOP.

2015-07-30 Thread Andy Zhou
On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote: > We already queue the removal of the kernel module in OVS_VSWITCHD_START, > via an ON_EXIT() call. This redundant removal also doesn't interact very > well with usage of vports: If the datapath still exists in the kernel, > we cannot remove a v

Re: [ovs-dev] [PATCH 2/3] kmod-macros: Don't unload kmod in VSWITCHD_STOP.

2015-07-30 Thread Daniele Di Proietto
Acked-by: Daniele Di Proietto On 30/07/2015 00:52, "Joe Stringer" wrote: >We already queue the removal of the kernel module in OVS_VSWITCHD_START, >via an ON_EXIT() call. This redundant removal also doesn't interact very >well with usage of vports: If the datapath still exists in the kernel, >

[ovs-dev] [PATCH 2/3] kmod-macros: Don't unload kmod in VSWITCHD_STOP.

2015-07-29 Thread Joe Stringer
We already queue the removal of the kernel module in OVS_VSWITCHD_START, via an ON_EXIT() call. This redundant removal also doesn't interact very well with usage of vports: If the datapath still exists in the kernel, we cannot remove a vport module; if we cannot remove a vport module, we cannot rem