Re: [ovs-dev] [PATCH 2/3] flow: Adds ethernet mask fields to flow_wildcards

2012-05-16 Thread Jean Tourrilhes
Joe Stringer wrote : > > With OpenFlow 1.1, there is no equivalent ofp_flow_wildcards flags > for ethernet masking; this is replaced by the eth_{src,dst}_mask. To > support this fully, will we set the appropriate > FWW_DL_DST/FWW_ETH_MCAST bits in the wildcards_t when translating > from OF11+? Or

Re: [ovs-dev] [PATCH 2/3] flow: Adds ethernet mask fields to flow_wildcards

2012-05-16 Thread Ben Pfaff
On Wed, May 16, 2012 at 01:16:17PM +1200, Joe Stringer wrote: > Arbitrary ethernet mask support is one step on the way to support for OpenFlow > 1.0+. This patch set seeks to add this capability without breaking current > protocol support. Thank you for doing this! I have some comments. > This p

Re: [ovs-dev] [PATCH 2/3] flow: Adds ethernet mask fields to flow_wildcards

2012-05-15 Thread Joe Stringer
Apologies on the whitespace "fixes" -- I realise I didn't go back over the CodingStyle before mailing the patches. Please ignore those parts for the purposes of reviewing. I was expecting to need to make other changes and resubmit newer patches after I get some feedback, so please ignore these for

[ovs-dev] [PATCH 2/3] flow: Adds ethernet mask fields to flow_wildcards

2012-05-15 Thread Joe Stringer
Arbitrary ethernet mask support is one step on the way to support for OpenFlow 1.0+. This patch set seeks to add this capability without breaking current protocol support. This patch also includes some whitespace fixes -- ^L replaced with empty lines. Signed-off-by: Joe Stringer --- Initial intr