Re: [ovs-dev] [PATCH 2/3] OVSDB: only update monitor when necessary

2015-06-22 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 01:21:10PM -0700, Andy Zhou wrote: > > I'm not sure that 'efficacy' is the best term here, but it is at least > > distinctive. > > > > How about 'update_level'? Any other suggestions? Let's stick with efficacy for now, it's growing on me. _

Re: [ovs-dev] [PATCH 2/3] OVSDB: only update monitor when necessary

2015-06-22 Thread Andy Zhou
> I'm not sure that 'efficacy' is the best term here, but it is at least > distinctive. > How about 'update_level'? Any other suggestions? > Acked-by: Ben Pfaff Thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/d

Re: [ovs-dev] [PATCH 2/3] OVSDB: only update monitor when necessary

2015-06-22 Thread Ben Pfaff
On Wed, Jun 10, 2015 at 06:37:58PM -0700, Andy Zhou wrote: > Some DB modification transactions won't affect the columns of a monitor. > Skip those updates. > > Signed-off-by: Andy Zhou It wasn't obvious to me until patch 3 that the order of the OVSDB_CHANGES_* enums was important. Would you min

[ovs-dev] [PATCH 2/3] OVSDB: only update monitor when necessary

2015-06-10 Thread Andy Zhou
Some DB modification transactions won't affect the columns of a monitor. Skip those updates. Signed-off-by: Andy Zhou --- ovsdb/monitor.c | 68 - 1 file changed, 67 insertions(+), 1 deletion(-) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.