Re: [ovs-dev] [PATCH 2/2 net-next] openvswitch: Use skb_zerocopy() for upcall

2013-11-10 Thread Jesse Gross
On Mon, Nov 11, 2013 at 7:40 AM, Thomas Graf wrote: > On 11/09/13 at 10:02pm, Ben Hutchings wrote: >> On Fri, 2013-11-08 at 10:15 +0100, Thomas Graf wrote: >> > Use of skb_zerocopy() avoids the expensive call to memcpy() when >> > copying the packet data into the Netlink skb. Completes checksum >>

Re: [ovs-dev] [PATCH 2/2 net-next] openvswitch: Use skb_zerocopy() for upcall

2013-11-10 Thread Thomas Graf
On 11/09/13 at 10:02pm, Ben Hutchings wrote: > On Fri, 2013-11-08 at 10:15 +0100, Thomas Graf wrote: > > Use of skb_zerocopy() avoids the expensive call to memcpy() when > > copying the packet data into the Netlink skb. Completes checksum > > through skb_checksum_help() if needed. > > > > Netlink

Re: [ovs-dev] [PATCH 2/2 net-next] openvswitch: Use skb_zerocopy() for upcall

2013-11-09 Thread Ben Hutchings
On Fri, 2013-11-08 at 10:15 +0100, Thomas Graf wrote: > Use of skb_zerocopy() avoids the expensive call to memcpy() when > copying the packet data into the Netlink skb. Completes checksum > through skb_checksum_help() if needed. > > Netlink messaged must be properly padded and aligned to meet > sa

Re: [ovs-dev] [PATCH 2/2 net-next] openvswitch: Use skb_zerocopy() for upcall

2013-11-08 Thread Daniel Borkmann
On 11/08/2013 11:47 AM, Thomas Graf wrote: Use of skb_zerocopy() avoids the expensive call to memcpy() when copying the packet data into the Netlink skb. Completes checksum through skb_checksum_help() if needed. Netlink messaged must be properly padded and aligned to meet sanity checks of the us

[ovs-dev] [PATCH 2/2 net-next] openvswitch: Use skb_zerocopy() for upcall

2013-11-08 Thread Thomas Graf
Use of skb_zerocopy() avoids the expensive call to memcpy() when copying the packet data into the Netlink skb. Completes checksum through skb_checksum_help() if needed. Netlink messaged must be properly padded and aligned to meet sanity checks of the user space counterpart. Cost of memcpy is sign

[ovs-dev] [PATCH 2/2 net-next] openvswitch: Use skb_zerocopy() for upcall

2013-11-08 Thread Thomas Graf
Use of skb_zerocopy() avoids the expensive call to memcpy() when copying the packet data into the Netlink skb. Completes checksum through skb_checksum_help() if needed. Netlink messaged must be properly padded and aligned to meet sanity checks of the user space counterpart. Cost of memcpy is sign