Re: [ovs-dev] [PATCH 2/2] tunnel: Do not set padding bits in tunnel mask.

2014-03-01 Thread Ben Pfaff
Thanks, I fixed that. I'll push this in a moment. On Sat, Mar 01, 2014 at 05:30:55PM -0800, Ethan Jackson wrote: > You mispelled commit in the commit message. > > > Acked-by: Ethan Jackson > > > On Sat, Mar 1, 2014 at 5:25 PM, Ben Pfaff wrote: > > On most architectures other than 32-bit x86

Re: [ovs-dev] [PATCH 2/2] tunnel: Do not set padding bits in tunnel mask.

2014-03-01 Thread Ethan Jackson
You mispelled commit in the commit message. Acked-by: Ethan Jackson On Sat, Mar 1, 2014 at 5:25 PM, Ben Pfaff wrote: > On most architectures other than 32-bit x86, struct flow_tnl ends with 4 > padding bytes. Until now, tnl_xlate_init() set those bytes to nonzero > values in the wildcard mas

[ovs-dev] [PATCH 2/2] tunnel: Do not set padding bits in tunnel mask.

2014-03-01 Thread Ben Pfaff
On most architectures other than 32-bit x86, struct flow_tnl ends with 4 padding bytes. Until now, tnl_xlate_init() set those bytes to nonzero values in the wildcard mask. When the wildcard mask passed through Netlink attributes and back to userspace, the padding bytes of course became zero again