Re: [ovs-dev] [PATCH 2/2] tests: Test ofproto-dpif set_tunnel translation.

2011-09-12 Thread Ethan Jackson
Thanks for the reviews. Ethan On Mon, Sep 12, 2011 at 19:10, Ben Pfaff wrote: > It's fine. > > On Mon, Sep 12, 2011 at 06:47:36PM -0700, Ethan Jackson wrote: >> I just thought it was easier to read.  One line per output.  If you >> disagree I can squash it. >> >> Ethan >> >> On Mon, Sep 12, 2011

Re: [ovs-dev] [PATCH 2/2] tests: Test ofproto-dpif set_tunnel translation.

2011-09-12 Thread Ben Pfaff
It's fine. On Mon, Sep 12, 2011 at 06:47:36PM -0700, Ethan Jackson wrote: > I just thought it was easier to read. One line per output. If you > disagree I can squash it. > > Ethan > > On Mon, Sep 12, 2011 at 18:47, Ben Pfaff wrote: > > On Mon, Sep 12, 2011 at 05:43:26PM -0700, Ethan Jackson w

Re: [ovs-dev] [PATCH 2/2] tests: Test ofproto-dpif set_tunnel translation.

2011-09-12 Thread Ethan Jackson
I just thought it was easier to read. One line per output. If you disagree I can squash it. Ethan On Mon, Sep 12, 2011 at 18:47, Ben Pfaff wrote: > On Mon, Sep 12, 2011 at 05:43:26PM -0700, Ethan Jackson wrote: >> This patch adds a unit test which would have caught the issue fixed >> in Commit

Re: [ovs-dev] [PATCH 2/2] tests: Test ofproto-dpif set_tunnel translation.

2011-09-12 Thread Ben Pfaff
On Mon, Sep 12, 2011 at 05:43:26PM -0700, Ethan Jackson wrote: > This patch adds a unit test which would have caught the issue fixed > in Commit 2446268e "ofproto-dpif: set_tunnel when required to." Did you copy this from a test of resubmit? Otherwise why all the resubmits? I don't see any actua

[ovs-dev] [PATCH 2/2] tests: Test ofproto-dpif set_tunnel translation.

2011-09-12 Thread Ethan Jackson
This patch adds a unit test which would have caught the issue fixed in Commit 2446268e "ofproto-dpif: set_tunnel when required to." --- tests/ofproto-dpif.at | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at ind