Re: [ovs-dev] [PATCH 2/2] tests: Fix race in async config test.

2014-12-04 Thread Joe Stringer
Thanks for the review, I made that change and pushed this series to master. On 4 December 2014 at 11:23, Alex Wang wrote: > Since we stop the time, should we add a warp before calling > ovs-appctl netdev-dummy/receive ? > > Otherwise, looks good to me, > Acked-by: Alex Wang > > > On Wed, Dec 3,

Re: [ovs-dev] [PATCH 2/2] tests: Fix race in async config test.

2014-12-04 Thread Alex Wang
Since we stop the time, should we add a warp before calling ovs-appctl netdev-dummy/receive ? Otherwise, looks good to me, Acked-by: Alex Wang On Wed, Dec 3, 2014 at 11:07 AM, Joe Stringer wrote: > Occasionally, the testsuite would send the OFPT_SET_ASYNC before > ovs-vswitchd got a chance to

[ovs-dev] [PATCH 2/2] tests: Fix race in async config test.

2014-12-03 Thread Joe Stringer
Occasionally, the testsuite would send the OFPT_SET_ASYNC before ovs-vswitchd got a chance to send its OFPT_ROLE_REPLY message, causing a reordering of the testsuite output and a false positive. Give the test script something extra to do so this is less likely to happen. Signed-off-by: Joe Stringe