Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-29 Thread Guru Shetty
I did spend quite some time looking at this code and VTEP schema. The goal for me has been not only to review this piece only for VTEP emulator but also to see the future viability of using this in a L3 edge device for OVN. I feel that it may make sense to step back a bit and rethink the whole arch

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-23 Thread Justin Pettit
> On Dec 23, 2015, at 12:49 AM, Ben Pfaff wrote: > >> On Mon, Dec 07, 2015 at 09:58:53AM -0800, Justin Pettit wrote: >> >>> On Dec 7, 2015, at 9:15 AM, Ben Pfaff wrote: >>> >>> On Tue, Dec 08, 2015 at 07:35:44AM +0800, Shuangmin Zhang wrote: This patch is to support L3 DLR E-W traffic fu

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-22 Thread Ben Pfaff
On Mon, Dec 07, 2015 at 09:58:53AM -0800, Justin Pettit wrote: > > > On Dec 7, 2015, at 9:15 AM, Ben Pfaff wrote: > > > > On Tue, Dec 08, 2015 at 07:35:44AM +0800, Shuangmin Zhang wrote: > >> This patch is to support L3 DLR E-W traffic functionality in ovs-vtep. So > >> it is focus on supportin

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Ben Pfaff
Using "git format-patch -1" if you want to generate one patch. On Mon, Dec 07, 2015 at 11:19:41PM +, Shuangmin Zhang wrote: > Yeah, while I generated patch with form-patch, it generated 2 patches, > another is 0001-ofproto-dpif-Validate-NAT-action-support.patch, but that > is not my code cha

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Shuangmin Zhang
Yeah, while I generated patch with form-patch, it generated 2 patches, another is 0001-ofproto-dpif-Validate-NAT-action-support.patch, but that is not my code change, don¹t know why it comes up. It is a already checkin-patch by Daniele Di. Thanks Shuangmin. On 12/8/15, 1:58 AM, "Justin Pettit"

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Justin Pettit
> On Dec 7, 2015, at 9:15 AM, Ben Pfaff wrote: > > On Tue, Dec 08, 2015 at 07:35:44AM +0800, Shuangmin Zhang wrote: >> This patch is to support L3 DLR E-W traffic functionality in ovs-vtep. So it >> is focus on supporting switch-binding field in Logical_Router Table schema. >> >> Like what we

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Ben Pfaff
On Tue, Dec 08, 2015 at 07:35:44AM +0800, Shuangmin Zhang wrote: > This patch is to support L3 DLR E-W traffic functionality in ovs-vtep. So it > is focus on supporting switch-binding field in Logical_Router Table schema. > > Like what we do for logical switch, there are 2 parts of work Is ther

[ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Shuangmin Zhang
This patch is to support L3 DLR E-W traffic functionality in ovs-vtep. So it is focus on supporting switch-binding field in Logical_Router Table schema. Like what we do for logical switch, there are 2 parts of work 1> physical handling In this part, create binding between logical router and