Re: [ovs-dev] [PATCH 2/2] stream: By default disable probing on unix sockets.

2012-04-13 Thread Ethan Jackson
Thanks for reviewing the code so carefully. I'll merge this later tonight when I get home. Ethan (iPhone) On Apr 13, 2012, at 20:41, Ben Pfaff wrote: > On Wed, Apr 11, 2012 at 11:50:22PM -0700, Ethan Jackson wrote: >>> Should we update any documentation or NEWS? >> >> The documentation I've

Re: [ovs-dev] [PATCH 2/2] stream: By default disable probing on unix sockets.

2012-04-13 Thread Ben Pfaff
On Wed, Apr 11, 2012 at 11:50:22PM -0700, Ethan Jackson wrote: > > Should we update any documentation or NEWS? > > The documentation I've looked at doesn't mention a default value so I don't > think it needs to change. I can't imagine that any users will really care > that > we don't send echo's

Re: [ovs-dev] [PATCH 2/2] stream: By default disable probing on unix sockets.

2012-04-13 Thread Ethan Jackson
> Should we update any documentation or NEWS? The documentation I've looked at doesn't mention a default value so I don't think it needs to change. I can't imagine that any users will really care that we don't send echo's on unix sockets so I'm reluctant to add it to the NEWS. The following is a

Re: [ovs-dev] [PATCH 2/2] stream: By default disable probing on unix sockets.

2012-04-13 Thread Ben Pfaff
On Wed, Apr 11, 2012 at 10:02:10PM -0700, Ethan Jackson wrote: > There isn't a lot of value in sending inactivity probes on unix > sockets. This patch changes the default to disable them. > > Signed-off-by: Ethan Jackson I'm half-inclined to just write a single function that can take either a s

[ovs-dev] [PATCH 2/2] stream: By default disable probing on unix sockets.

2012-04-13 Thread Ethan Jackson
There isn't a lot of value in sending inactivity probes on unix sockets. This patch changes the default to disable them. Signed-off-by: Ethan Jackson --- lib/jsonrpc.c |7 +++ lib/stream-fd.c|2 ++ lib/stream-provider.h | 10 ++ lib/stream-ssl.c |