Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-20 Thread Andy Zhou
Thanks for the updates and pushing it in. On Thu, Jun 20, 2013 at 10:34 AM, Ben Pfaff wrote: > On Tue, Jun 18, 2013 at 04:15:10PM -0700, Andy Zhou wrote: > > Added support to allow mega flow specified and displayed. ovs-dpctl tool > > is mainly used as debugging tool. > > > > This patch also im

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-20 Thread Ben Pfaff
On Tue, Jun 18, 2013 at 04:15:10PM -0700, Andy Zhou wrote: > Added support to allow mega flow specified and displayed. ovs-dpctl tool > is mainly used as debugging tool. > > This patch also implements the low level user space routines to send > and receive mega flow netlink messages. Those netlink

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-19 Thread Ben Pfaff
Good to hear, thank you. On Wed, Jun 19, 2013 at 06:42:59PM -0700, Jesse Gross wrote: > I added most of the ones that seemed important during my cleanups > yesterday. The only other thing that comes to mind is a description of > how updates are handled (such as the fact that the new mask is > igno

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-19 Thread Jesse Gross
I added most of the ones that seemed important during my cleanups yesterday. The only other thing that comes to mind is a description of how updates are handled (such as the fact that the new mask is ignored). On Wed, Jun 19, 2013 at 3:04 PM, Andy Zhou wrote: > Good idea. There may be other aspec

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-19 Thread Andy Zhou
Good idea. There may be other aspects of the mega related kernel ABI needs document as well. Wonder if Justin and Jesse have more inputs on this. On Wed, Jun 19, 2013 at 2:55 PM, Ben Pfaff wrote: > OK, can we add that in the tree somewhere, maybe datapath/README? > > Thanks, > > Ben. > > On Wed

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-19 Thread Ben Pfaff
OK, can we add that in the tree somewhere, maybe datapath/README? Thanks, Ben. On Wed, Jun 19, 2013 at 02:52:52PM -0700, Andy Zhou wrote: > It is a good idea to capture this information in a table. The following > table should be accurate: > > Pre-megaflow: > > typemask

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-19 Thread Andy Zhou
It is a good idea to capture this information in a table. The following table should be accurate: Pre-megaflow: typemask matches --- eth_type(0x600+) specified Ethertype II, or val

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-19 Thread Ben Pfaff
I don't really care about the formatting, only about the kernel ABI. Pre-megaflows, the ABI was: typemask matches --- eth_type(0x600+) specified Ethertype II Ethertype.

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-19 Thread Andy Zhou
We will continue to allow missing eth_type in the netlink attribute to imply Ethernet II type. 802.3 frames requires a specific eth_type attribute. With Mega flows, we further require a missing eth_type in the key attribute to have a exact match (ox) in the eth_type of the mask attribute (if p

Re: [ovs-dev] [PATCH 2/2] ovs-dpctl: Add mega flow support

2013-06-19 Thread Ben Pfaff
On Tue, Jun 18, 2013 at 04:15:10PM -0700, Andy Zhou wrote: > Added support to allow mega flow specified and displayed. ovs-dpctl tool > is mainly used as debugging tool. > > This patch also implements the low level user space routines to send > and receive mega flow netlink messages. Those netlink