Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: restore bond rebalance for non-recirc bond

2014-04-29 Thread Andy Zhou
I upgraded my clang from 3.4 to 3.5. Now I can also reproduce the warning message. On Tue, Apr 29, 2014 at 2:32 AM, Simon Horman wrote: > Thanks. > > On Tue, Apr 29, 2014 at 02:30:26AM -0700, Andy Zhou wrote: >> Good catch. Thanks for pointing it out. I will send out patch to fix this. >> >> On T

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: restore bond rebalance for non-recirc bond

2014-04-29 Thread Simon Horman
Thanks. On Tue, Apr 29, 2014 at 02:30:26AM -0700, Andy Zhou wrote: > Good catch. Thanks for pointing it out. I will send out patch to fix this. > > On Tue, Apr 29, 2014 at 2:14 AM, Simon Horman wrote: > > On Thu, Apr 24, 2014 at 10:34:15PM -0700, Andy Zhou wrote: > >> Bond rebalancing was disabl

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: restore bond rebalance for non-recirc bond

2014-04-29 Thread Andy Zhou
Good catch. Thanks for pointing it out. I will send out patch to fix this. On Tue, Apr 29, 2014 at 2:14 AM, Simon Horman wrote: > On Thu, Apr 24, 2014 at 10:34:15PM -0700, Andy Zhou wrote: >> Bond rebalancing was disabled for bonds not using recirculation. The >> patch fixes this bug. >> >> While

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: restore bond rebalance for non-recirc bond

2014-04-29 Thread Simon Horman
On Thu, Apr 24, 2014 at 10:34:15PM -0700, Andy Zhou wrote: > Bond rebalancing was disabled for bonds not using recirculation. The > patch fixes this bug. > > While fixing the bug, the bond_rebalance() was also restructured > slightly to move bond related logic back into ofproto/bond.c > > Signed-

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: restore bond rebalance for non-recirc bond

2014-04-28 Thread Ben Pfaff
On Thu, Apr 24, 2014 at 10:34:15PM -0700, Andy Zhou wrote: > Bond rebalancing was disabled for bonds not using recirculation. The > patch fixes this bug. > > While fixing the bug, the bond_rebalance() was also restructured > slightly to move bond related logic back into ofproto/bond.c > > Signed-

[ovs-dev] [PATCH 2/2] ofproto-dpif: restore bond rebalance for non-recirc bond

2014-04-24 Thread Andy Zhou
Bond rebalancing was disabled for bonds not using recirculation. The patch fixes this bug. While fixing the bug, the bond_rebalance() was also restructured slightly to move bond related logic back into ofproto/bond.c Signed-off-by: Andy Zhou --- ofproto/bond.c | 21 +++--