Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: Add ability to disable megaflows.

2013-06-28 Thread Justin Pettit
On Jun 28, 2013, at 5:37 PM, Ethan Jackson wrote: > Please put a period after the Feature number. Not sure why, but > that's been the convention. Okay. > Instead of calling the variable "disable_megaflows", I think the code > would be a bit easier to read if we called it "megaflows" and > ini

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: Add ability to disable megaflows.

2013-06-28 Thread Ethan Jackson
Please put a period after the Feature number. Not sure why, but that's been the convention. Instead of calling the variable "disable_megaflows", I think the code would be a bit easier to read if we called it "megaflows" and initialize it to true. Negative flags are a bit confusing. I don't thin

[ovs-dev] [PATCH 2/2] ofproto-dpif: Add ability to disable megaflows.

2013-06-28 Thread Justin Pettit
Add new "dpif/disable-megaflows" and "dpif/enable-megaflows" commands to ovs-appctl to disable and enable megaflows, respectively. By default, megaflows are enabled, and these commands should only be used for debugging. Feature #18265 Requested-by: Ronghua Zhang Signed-off-by: Justin Pettit --