Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Fix a bug in netdev_dpdk_set_multiq().

2014-09-19 Thread Alex Wang
Thx, pushed to master, On Fri, Sep 19, 2014 at 11:49 AM, Alex Wang wrote: > sure, i'm okay with that, > > > On Fri, Sep 19, 2014 at 11:22 AM, Daniele Di Proietto < > ddiproie...@vmware.com> wrote: > >> How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹? >> IMHO it is more cl

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Fix a bug in netdev_dpdk_set_multiq().

2014-09-19 Thread Alex Wang
sure, i'm okay with that, On Fri, Sep 19, 2014 at 11:22 AM, Daniele Di Proietto < ddiproie...@vmware.com> wrote: > How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹? > IMHO it is more clear that it is allocating memory without freeing it. > > Otherwise, LGTM. Thanks for the

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Fix a bug in netdev_dpdk_set_multiq().

2014-09-19 Thread Daniele Di Proietto
How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹? IMHO it is more clear that it is allocating memory without freeing it. Otherwise, LGTM. Thanks for the fix Acked-by: Daniele Di Proietto On 9/19/14, 10:57 AM, "Alex Wang" wrote: >Commit 5a0340 (dpif-netdev: Create multip

[ovs-dev] [PATCH 2/2] netdev-dpdk: Fix a bug in netdev_dpdk_set_multiq().

2014-09-19 Thread Alex Wang
Commit 5a0340 (dpif-netdev: Create multiple tx/rx queues when adding dpdk interface.) introduced a bug which causes the function netdev_dpdk_set_multiq() never resetting the tx queues. This bug could cause pmd thread accessing unassigned memory, resulting in segfault. This commit fixes the bug.