Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-13 Thread Traynor, Kevin
e > running the tests so that I have something to go with. > > Thanks, > > Jarno > > > Regards, > > Ciara > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno Rajahalme > > Sent: Wednesd

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-12 Thread Jarno Rajahalme
-Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno Rajahalme > Sent: Wednesday, December 17, 2014 6:31 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data. > > So far the compressed flow data in struc

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-12 Thread Loftus, Ciara
Of Jarno Rajahalme Sent: Wednesday, December 17, 2014 6:31 PM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data. So far the compressed flow data in struct miniflow has been in 32-bit words with a 63-bit map, allowing for a maximum size of struct flow of 252 bytes. W

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-06 Thread Jarno Rajahalme
On Jan 6, 2015, at 1:20 PM, Ben Pfaff wrote: > On Tue, Jan 06, 2015 at 11:03:15AM -0800, Jarno Rajahalme wrote: >> >> On Jan 5, 2015, at 2:39 PM, Ben Pfaff wrote: >> >>> On Mon, Jan 05, 2015 at 02:15:13PM -0800, Ben Pfaff wrote: On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme w

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-06 Thread Ben Pfaff
On Tue, Jan 06, 2015 at 11:03:15AM -0800, Jarno Rajahalme wrote: > > On Jan 5, 2015, at 2:39 PM, Ben Pfaff wrote: > > > On Mon, Jan 05, 2015 at 02:15:13PM -0800, Ben Pfaff wrote: > >> On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme wrote: > >>> > >>> On Dec 29, 2014, at 2:27 PM, Ben P

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-06 Thread Jarno Rajahalme
On Jan 5, 2015, at 2:39 PM, Ben Pfaff wrote: > On Mon, Jan 05, 2015 at 02:15:13PM -0800, Ben Pfaff wrote: >> On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme wrote: >>> >>> On Dec 29, 2014, at 2:27 PM, Ben Pfaff wrote: >>> On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalm

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-05 Thread Ben Pfaff
On Mon, Jan 05, 2015 at 02:15:13PM -0800, Ben Pfaff wrote: > On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme wrote: > > > > On Dec 29, 2014, at 2:27 PM, Ben Pfaff wrote: > > > > > On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalme wrote: > > >> So far the compressed flow data in

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-05 Thread Ben Pfaff
On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme wrote: > > On Dec 29, 2014, at 2:27 PM, Ben Pfaff wrote: > > > On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalme wrote: > >> So far the compressed flow data in struct miniflow has been in 32-bit > >> words with a 63-bit map, allow

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-05 Thread Jarno Rajahalme
On Dec 29, 2014, at 2:27 PM, Ben Pfaff wrote: > On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalme wrote: >> So far the compressed flow data in struct miniflow has been in 32-bit >> words with a 63-bit map, allowing for a maximum size of struct flow of >> 252 bytes. With the forthcoming

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-29 Thread Ben Pfaff
On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalme wrote: > So far the compressed flow data in struct miniflow has been in 32-bit > words with a 63-bit map, allowing for a maximum size of struct flow of > 252 bytes. With the forthcoming Geneve options this is not sufficient > any more. > >

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Madhu Challa
Thanks for the helpful explanation. Thanks. On Wed, Dec 17, 2014 at 12:45 PM, Jarno Rajahalme wrote: > > > On Dec 17, 2014, at 12:07 PM, Madhu Challa > wrote: > > Jarno, > > I did some simple tests increasing flow_tnl size and trying to match on it > looks good. Thanks for solving this. I have

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Jarno Rajahalme
On Dec 17, 2014, at 12:07 PM, Madhu Challa wrote: > Jarno, > > I did some simple tests increasing flow_tnl size and trying to match on it > looks good. Thanks for solving this. I have a question inline around > miniflow_extract. Other than that the diff looks good to me. > > Thanks. > > On

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Madhu Challa
Jarno, I did some simple tests increasing flow_tnl size and trying to match on it looks good. Thanks for solving this. I have a question inline around miniflow_extract. Other than that the diff looks good to me. Thanks. On Wed, Dec 17, 2014 at 10:30 AM, Jarno Rajahalme wrote: > > So far the com

[ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Jarno Rajahalme
So far the compressed flow data in struct miniflow has been in 32-bit words with a 63-bit map, allowing for a maximum size of struct flow of 252 bytes. With the forthcoming Geneve options this is not sufficient any more. This patch solves the problem by changing the miniflow data to 64-bit words,