Re: [ovs-dev] [PATCH 2/2] match: Format entire ODP port number in match_format().

2016-02-01 Thread Ben Pfaff
On Mon, Feb 01, 2016 at 10:51:58PM +0100, Dimitri John Ledkov wrote: > Build log for powerpc platform: > > https://launchpadlibrarian.net/235964133/buildlog_ubuntu-xenial-powerpc.openvswitch_2.5.0~git20160129.46a88d9-0ubuntu2.1_BUILDING.txt.gz > > Ctrl-F for "testsuite: command line was:" to jump

Re: [ovs-dev] [PATCH 2/2] match: Format entire ODP port number in match_format().

2016-02-01 Thread Dimitri John Ledkov
On 1 February 2016 at 22:51, Dimitri John Ledkov wrote: > Build log for powerpc platform: > > https://launchpadlibrarian.net/235964133/buildlog_ubuntu-xenial-powerpc.openvswitch_2.5.0~git20160129.46a88d9-0ubuntu2.1_BUILDING.txt.gz > > Ctrl-F for "testsuite: command line was:" to jump to the "cat >

Re: [ovs-dev] [PATCH 2/2] match: Format entire ODP port number in match_format().

2016-02-01 Thread Dimitri John Ledkov
Build log for powerpc platform: https://launchpadlibrarian.net/235964133/buildlog_ubuntu-xenial-powerpc.openvswitch_2.5.0~git20160129.46a88d9-0ubuntu2.1_BUILDING.txt.gz Ctrl-F for "testsuite: command line was:" to jump to the "cat tests/testuite.log" output. There are now 22 failures: Subject:

Re: [ovs-dev] [PATCH 2/2] match: Format entire ODP port number in match_format().

2016-02-01 Thread Dimitri John Ledkov
Hello, The reasoning sounds good, but i wouldn't understand this just by looking at the patch. Let me test build these both patches, and I'll let you know the results soon. Regards, Dimitri. On 1 February 2016 at 21:55, Ben Pfaff wrote: > struct flow has a union for the in_port field, and the

[ovs-dev] [PATCH 2/2] match: Format entire ODP port number in match_format().

2016-02-01 Thread Ben Pfaff
struct flow has a union for the in_port field, and the two different members of the union have different sizes: ofp_port_t is 16 bits, odp_port_t is 32 bits. On little-endian machines this doesn't matter much, but on big-endian machines it's important to distinguish between them because a small nu