Re: [ovs-dev] [PATCH 2/2] lockfile: Remove lockfile_lock timeout argument

2012-08-09 Thread Leo Alterman
Thanks, Ben. Incorporated changes and resubmitted patch set since the order changed. On Wed, Aug 8, 2012 at 9:26 PM, Ben Pfaff wrote: > On Wed, Aug 08, 2012 at 05:52:58PM -0700, Leo Alterman wrote: > > lockfile_lock() accepts a timeout argument but, aside from unit tests > > pertaining to timeou

Re: [ovs-dev] [PATCH 2/2] lockfile: Remove lockfile_lock timeout argument

2012-08-08 Thread Ben Pfaff
On Wed, Aug 08, 2012 at 05:52:58PM -0700, Leo Alterman wrote: > lockfile_lock() accepts a timeout argument but, aside from unit tests > pertaining to timeout, its value is always 0. Since this feature relies on > a periodic SIGALRM signal, which is no longer a given after refactoring > timeval.c, t

[ovs-dev] [PATCH 2/2] lockfile: Remove lockfile_lock timeout argument

2012-08-08 Thread Leo Alterman
lockfile_lock() accepts a timeout argument but, aside from unit tests pertaining to timeout, its value is always 0. Since this feature relies on a periodic SIGALRM signal, which is no longer a given after refactoring timeval.c, the cleanest solution is to just remove it. Signed-off-by: Leo Alterma