Re: [ovs-dev] [PATCH 2/2] db-ctl-base: make cmd_show_table private

2015-07-23 Thread Andy Zhou
On Tue, Jul 21, 2015 at 11:43 AM, Ben Pfaff wrote: > On Fri, Jul 17, 2015 at 05:12:45PM -0700, Andy Zhou wrote: >> Instead of requiring user to declare a global variable, pass the value >> via ctl_init(). >> >> Signed-off-by: Andy Zhou > > I think that cmd_show_tables should be 'static'. Absolute

Re: [ovs-dev] [PATCH 2/2] db-ctl-base: make cmd_show_table private

2015-07-21 Thread Ben Pfaff
On Fri, Jul 17, 2015 at 05:12:45PM -0700, Andy Zhou wrote: > Instead of requiring user to declare a global variable, pass the value > via ctl_init(). > > Signed-off-by: Andy Zhou I think that cmd_show_tables should be 'static'. Acked-by: Ben Pfaff __

[ovs-dev] [PATCH 2/2] db-ctl-base: make cmd_show_table private

2015-07-17 Thread Andy Zhou
Instead of requiring user to declare a global variable, pass the value via ctl_init(). Signed-off-by: Andy Zhou --- lib/db-ctl-base.c | 20 +++- lib/db-ctl-base.h | 17 +++-- utilities/ovs-vsctl.c | 4 ++-- vtep/vtep-ctl.c | 4 ++-- 4 files changed, 18