Re: [ovs-dev] [PATCH 2/2] datapath: Use nla_parse_strict() for netlink parsing.

2014-08-28 Thread Joe Stringer
On 29 August 2014 15:57, Pravin Shelar wrote: > > I have not finished review but I was wonder if you can get rid of the > attributes bit mask also? > Hi Pravin, I took a look, and I think I can reduce it down to just being inside match_validate() without much trouble. I don't have a good feel f

Re: [ovs-dev] [PATCH 2/2] datapath: Use nla_parse_strict() for netlink parsing.

2014-08-28 Thread Pravin Shelar
On Tue, Aug 26, 2014 at 4:50 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > datapath/flow_netlink.c | 219 > +++ > 1 file changed, 86 insertions(+), 133 deletions(-) > > diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c >

[ovs-dev] [PATCH 2/2] datapath: Use nla_parse_strict() for netlink parsing.

2014-08-26 Thread Joe Stringer
Signed-off-by: Joe Stringer --- datapath/flow_netlink.c | 219 +++ 1 file changed, 86 insertions(+), 133 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index 69d1919..aa2cece 100644 --- a/datapath/flow_netlink.c +++ b/data