Re: [ovs-dev] [PATCH 2/2] bridge.c: Always call smap_destroy() after smap_init()

2013-09-12 Thread Ansis Atteka
On Wed, Sep 11, 2013 at 5:19 PM, Alex Wang wrote: > This commit fixes a place in bridge.c where smap_destroy() is not > always called after smap_init(). Though there is no memory leak > now, it is necessary to fix it and prevent memory leak in the > future when smap_init() may be modified to allo

Re: [ovs-dev] [PATCH 2/2] bridge.c: Always call smap_destroy() after smap_init()

2013-09-12 Thread Alex Wang
Thanks for the tip. I'll resend a v2, ;D On Thu, Sep 12, 2013 at 9:52 AM, Ansis Atteka wrote: > On Wed, Sep 11, 2013 at 5:19 PM, Alex Wang wrote: > > This commit fixes a place in bridge.c where smap_destroy() is not > > always called after smap_init(). Though there is no memory leak > > now

[ovs-dev] [PATCH 2/2] bridge.c: Always call smap_destroy() after smap_init()

2013-09-11 Thread Alex Wang
This commit fixes a place in bridge.c where smap_destroy() is not always called after smap_init(). Though there is no memory leak now, it is necessary to fix it and prevent memory leak in the future when smap_init() may be modified to allocate dynamic memory. Reported-by: Ansis Atteka Signed-off