Np, i'll adjust accordingly and send a v2 soon,
with the conjunction test.
On Tue, Aug 20, 2013 at 3:53 PM, Ethan Jackson wrote:
> > I don't understand. I have used a separate decay_rx_packets to record the
> > rx_packets stats for bfd decay. So, rx_packets is not shared.
>
> hmm I think you'r
> I don't understand. I have used a separate decay_rx_packets to record the
> rx_packets stats for bfd decay. So, rx_packets is not shared.
hmm I think you're right. I must have messed up rebasing.
Ethan
>
> But I'll definitely add an unit test running the two together.
>
>
>>
>> > +uint64_
Thanks Ethan for the review,
On Tue, Aug 20, 2013 at 3:07 PM, Ethan Jackson wrote:
> Does this patch work while decay mode is on? Won't the fact that we
> share rx_packets between the two features, and that it's set so
> frequently by the forwarding_if_rx feature, break the decay mode
> featur
Does this patch work while decay mode is on? Won't the fact that we
share rx_packets between the two features, and that it's set so
frequently by the forwarding_if_rx feature, break the decay mode
feature's assumption that it's the only one setting it? I'm surprised
this doesn't break the unit te
This commit adds a new boolean option "forwarding_if_rx" to bfd.
When forwarding_if_rx is true, the forwarding field in "ovs-appctl
bfd/show" output will still be true as long as there are incoming
packets received. This is for indicating the link liveness when
the link is congested and consecutiv
Thanks Ethan, for the review,
On Mon, Aug 5, 2013 at 3:58 PM, Ethan Jackson wrote:
> Thanks for writing this up, it's pretty close.
>
> In bfd_check_rx() the assertion makes me uncomfortable. I'd prefer we
> warn and reset bfd->rx_packets instead. Im worried that we could hit
> the assertion
Thanks for writing this up, it's pretty close.
In bfd_check_rx() the assertion makes me uncomfortable. I'd prefer we
warn and reset bfd->rx_packets instead. Im worried that we could hit
the assertion transiently during a configuration change.
I'd prefer we don't use the bfd->detect_time for thi
This commit adds a new boolean option "forwarding_if_rx" to bfd.
When forwarding_if_rx is true and BFD state is down, the forwarding
field in "ovs-appctl bfd/show" output will still be true as long as
there are incoming packets received. This is for indicating the
tunnel liveness when the tunnel i
